ruby one-liner for this possible?

Question

Any chance the 2nd and 3rd lines can be combined in an one-liner and hopefully save one valuable?

def self.date_format
  record = find_by_key('strftime')
  record ? record.value : "%Y-%b-%d'
end

the above function in a Config model try to fetch a database record by a key, return a default if not found in database.

Even better if can be written in named scope. Thanks

score 4 · Accepted Answer · answered Jun 04 '10 at 02:57

4

As requested.

Nobody yet has mentioned try, which is perfect for this situation:

value = find_by_key('strftime').try(:value) || "%Y-%b-%d"

answered Jun 04 '10 at 02:57

x1a4

1

Though `try` is not defined in ruby so you'd have to add `require 'active-support'` – Jakub Hampl Jun 04 '10 at 03:03
question is tagged with `named-scope` and `activemodel` so was assumed. – x1a4 Jun 04 '10 at 03:09

score 1 · Answer 2 · answered Jun 04 '10 at 10:28

1

You could use:

(find_by_key('strftime').value rescue nil) || "%Y-%b-%d"

though using exceptions is not very efficient.

answered Jun 04 '10 at 10:28

Luis

score 0 · Answer 3 · answered Jun 04 '10 at 02:37

0

Does

value = find_by_key('strftime') || "%Y-%b-%d"

work for you?

answered Jun 04 '10 at 02:37

Aidan Cully

sorry, return should be `reocrd.value`, not record – ohho Jun 04 '10 at 02:42
1

it's missing the `.value` call, but you can change it to `find_by_key('strftime').try(:value) || "%Y-%b-%d"` to keep it one line easily enough. – x1a4 Jun 04 '10 at 02:44
@x1a4, can you put it in an answer? such that I can credit you – ohho Jun 04 '10 at 02:52

score 0 · Answer 4 · answered Jun 04 '10 at 02:44

0

Do you need to assign a "value" variable at all? If not...

def self.date_format
  find_by_key('strftime') || "%Y-%b-%d"
end

answered Jun 04 '10 at 02:44

Alison R.

4 Answers4