Returning Data From Function (Swift)

Question

I am trying to return result and be able to access result array from this function. Everything is working in the function, however I cannot return anything or access results or any variable created inside the function from outside the closure. I want to access result.valueForKey("id") from outside the closure. How can I do that?

class ViewController: UIViewController, FBSDKLoginButtonDelegate {

var facebookid: NSString = ""
var username: NSString = ""
var userEmail:NSString = ""

override func viewDidLoad() {
    super.viewDidLoad()
    // Do any additional setup after loading the view, typically from a nib.

    if (FBSDKAccessToken.currentAccessToken() == nil)
    {
        let loginView : FBSDKLoginButton = FBSDKLoginButton()
        self.view.addSubview(loginView)
        loginView.center = self.view.center
        loginView.readPermissions = ["public_profile"]
        loginView.delegate = self

    } else {

        returnUserData()

        println(facebookid)  // This doesn't work

    }
}



    func returnUserData()
{

    let graphRequest : FBSDKGraphRequest = FBSDKGraphRequest(graphPath: "me", parameters: nil)
    graphRequest.startWithCompletionHandler({ (connection, result, error) -> Void in

        if ((error) != nil)
        {
            // Process error
            println("Error: \(error)")
        }
        else
        {

            self.facebookid = result.valueForKey("id") as NSString!
            self.username = result.valueForKey("name") as NSString!
            self.userEmail = result.valueForKey("email") as NSString!
            println(result) // This works


        }
    })
}

Edit: I did change the code according to the 2 answers below but still I still can't get any data return on the viewDidLoad closure. * println(facebookid) doesn't return anything in the ViewDidLoad whereas it does inside the closure in function.

There is probably little point in wrapping this operation inside another function - because it completes asynchronously you need to process the result in the completion handler closure. You can either pass another closure to `returnUserData` and invoke it from the completion handler or just inline this code where you need it and use the completion handler to process the result. The third option is to invoke some other function from the completion handler to process the result — Paulw11, Apr 10 '15 at 12:45
Maybe the parameters section shouldn't be nil. http://stackoverflow.com/questions/32031677/facebook-graph-api-get-request-should-contain-fields-parameter-swift-faceb — , Jan 15 '16 at 23:04

Ryann786 · Accepted Answer · 2015-04-10T13:08:30.217

You are creating the variables inside the closure meaning they can only be accessed inside.

You need to create the variables outside of the function at the top of you class.

for example

 class YourClassName {

      var facebookid
      var username
      var userEmail


 func returnUserData()
 {
     let graphRequest : FBSDKGraphRequest = FBSDKGraphRequest(graphPath:  "me", parameters: nil)
     graphRequest.startWithCompletionHandler({ (connection, result, error) -> Void in

    if ((error) != nil)
    {
        // Process error
        println("Error: \(error)")
    }
    else
    {
        self.facebookid = result.valueForKey("id") as? String
        self.userName = result.valueForKey("name") as? String
        self.userEmail = result.valueForKey("email") as? String

    }
  })
 }
}

Comments are not for extended discussion; this conversation has been [moved to chat](http://chat.stackoverflow.com/rooms/74959/discussion-on-answer-by-ryann786-returning-data-from-function-swift). — Taryn, Apr 10 '15 at 17:26

score 1 · Answer 2 · edited Nov 14 '17 at 11:18

func loginButton(_ loginButton: FBSDKLoginButton!, didCompleteWith result: FBSDKLoginManagerLoginResult!, error: Error!) {       
        if error != nil {
            print(error.localizedDescription)
            return
        }


                print("user loged in with facebook")
                if((FBSDKAccessToken.current()) != nil) {
                    FBSDKGraphRequest(graphPath: "me", parameters: ["fields": "id, name, first_name, last_name, email, age_range, link, gender, locale, timezone, updated_time, verified"]).start(completionHandler: { (connection, result, error) -> Void in
                        if (error == nil){
                            print(result!)
                            print("Token: \((FBSDKAccessToken.current().tokenString)!)")
                            print("Token Expiration Date: \((FBSDKAccessToken.current().expirationDate)!)")
                        }
                    })
                }

    }

Returning Data From Function (Swift)

2 Answers2

Linked