Synchronization in C# networking

Question

I have this simple tcp server class

 class Server
{
    private TcpListener tcpListener;
    private Thread listenThread;

    public Server()
    {
        this.tcpListener = new TcpListener(IPAddress.Parse("127.0.0.1"), 3000);
        this.listenThread = new Thread(new ThreadStart(ListenForClients));
        this.listenThread.Start();
        Console.WriteLine("Hello");
    }


    private void ListenForClients()
    {
        this.tcpListener.Start();

        while (true)
        {
            //blocks until a client has connected to the server
            TcpClient client = this.tcpListener.AcceptTcpClient();

            //create a thread to handle communication 
            //with connected client
            Thread clientThread = new Thread(new ParameterizedThreadStart(HandleClientComm));
            Console.WriteLine("New connexion");
            clientThread.Start(client);
        }
    }

    private void HandleClientComm(object client)
    {
        TcpClient tcpClient = (TcpClient)client;
        NetworkStream clientStream = tcpClient.GetStream();

        Console.WriteLine("Got Stream");

        byte[] message = new byte[4096];
        int bytesRead;

        Console.WriteLine("Initializing..");
        while (true)
        {
            bytesRead = 0;

            try
            {
                //blocks until a client sends a message
                Console.WriteLine("Reading..");
                bytesRead = clientStream.Read(message, 0, 4096);
                Console.WriteLine("Received something");
            }
            catch
            {
                //a socket error has occured
                break;
            }

            if (bytesRead == 0)
            {
                //the client has disconnected from the server
                break;
            }

            //message has successfully been received
            ASCIIEncoding encoder = new ASCIIEncoding();
            Console.WriteLine(encoder.GetString(message, 0, bytesRead));

        }

        tcpClient.Close();
    }

}

I simply call it in the main function like this :

Server server = new Server();

And in a separate client program I have this class

class TheClient
{
  public void ConnectV2()
    {


        TcpClient client = new TcpClient();

        IPEndPoint serverEndPoint = new IPEndPoint(IPAddress.Parse("127.0.0.1"), 3000);

        client.Connect(serverEndPoint);

        NetworkStream clientStream = client.GetStream();

        ASCIIEncoding encoder = new ASCIIEncoding();

        for (int i = 0; i < 20; i++)
        {

            byte[] buffer = encoder.GetBytes("Hello Server! " + i.ToString() + " ");

            Console.WriteLine("Processing..");

            clientStream.Write(buffer, 0, buffer.Length);
            clientStream.Flush();
            Console.WriteLine("Hello Server sent");
        }


    }

}

I call it in the main function like

TheClient tc = new TheClient();

tc.ConnectV2();

My problem is that the server program seems slower than the client, he don't react before the 13th, or more, message from the client :

[I can't post images because of reputation]

It reads the first dozen of messages in one go, and then reads the others one by one.

And if I make the server emit first, the client receive the message, but they both stop, like if both wait for the other to send something.

Can someone explain me this behavior ? How can I control and synchronize it ?

Might be worth knowing that "1 thread per connected client" doesn't scale up terribly well. — Damien_The_Unbeliever, Apr 10 '15 at 10:45

usr · Accepted Answer · 2015-04-11T08:46:44.343

2

TCP is not message based. It provides a stream of bytes. It is your responsibility to separate messages. Also note, that you might receive only a part of a message in one Read call.

Here's a simple way to do that: Send the messages as individual lines. Possibly using StreamWriter. Receive the messages using StreamReader.ReadLine().

That way you can also use a more sane encoding such as Encoding.UTF8.

Besides that your code is actually fine and workable. It is extremely rare to see almost working TCP code on Stack Overflow. Most code is horribly broken. Congratulations.

edited Apr 11 '15 at 08:46

answered Apr 10 '15 at 10:27

usr

168,620
35
240
369

I can't take the merit for it, I took it from a tutorial on the net, I just played with it a little bit to understand it – theTour Apr 10 '15 at 19:44
This must be the first tutorial on the web that shows nice socket code. Do you have a link? – usr Apr 10 '15 at 20:10
[Here you go](http://tech.pro/tutorial/704/csharp-tutorial-simple-threaded-tcp-server) – theTour Apr 10 '15 at 20:12
I just tried it, it works like a sharm. You made a little mistake it's `StreamReader.ReadLine()` not `StreamWriter.ReadLine()` . Thanks – theTour Apr 11 '15 at 01:18

score 0 · Answer 2 · edited Jun 20 '20 at 09:12

0

It's because that your client AP is always sending data ,but your server AP cannot receive those data right away. So,those data stacked in buffer and then server AP receive all at once.

You can try：

Set fixed lengths when you send or receive data.

or
Receive and split data.

edited Jun 20 '20 at 09:12

Community

1
1

answered Apr 10 '15 at 10:18

Angus Chung

1,547
1
11
13

Synchronization in C# networking

2 Answers2