'NoMethodError: undefined method' in Ruby on Rails Model

Question

I am creating a system that recurring payments each month so I am creating a new payment requirement using the whenever gem

The problem seems to be in my Payment model method, which is here.

class Payment < ActiveRecord::Base
  belongs_to :client

  def monthly_payment
    clients = Client.all
    clients.each do |client|
      Payment.create(month: Date.now, client_id: client.id)
    end
  end
end

In the cron.log I was getting a NoMethodError so I tried the method in the rails console and the same error appears:

NoMethodError: undefined method `monthly_payment' for Payment (call 'Payment.connection' to establish a connection):Class

Is there something wrong with the Model?

Here is the schema of Payment:

create_table "payments", force: :cascade do |t|
 t.date     "date"
 t.string   "type"
 t.date     "month"
 t.boolean  "paid"
 t.datetime "created_at", null: false
 t.datetime "updated_at", null: false
 t.integer  "client_id"
end

What's the command being run in cron that calls the code in `Payment` model? — Prakash Murthy, Apr 09 '15 at 14:24

MrYoshiji · Accepted Answer · 2015-04-09T14:30:39.413

8

You have to use a class method, not an instance method:

def self.monthly_payment # notice the self.
  clients = Client.all
  clients.each do |client|
    Payment.create(month: Date.now, client_id: client.id)
  end
end

So you will be able to call

Payment.monthly_payment # class method
# method that can be called only on the Payment class

And not

Payment.where(some_condition).first.monthly_payment # instance method
# method that can be called only on an instance of the Payment class

An interesting link about it: http://www.railstips.org/blog/archives/2009/05/11/class-and-instance-methods-in-ruby/

edited Apr 09 '15 at 14:30

answered Apr 09 '15 at 14:24

MrYoshiji

54,334
13
124
117

Silly mistake of mine. Anyway thanks a lot! I had not realised that. – LuigiAlver Apr 09 '15 at 19:08

score 0 · Answer 2 · edited Apr 09 '15 at 14:29

0

Try defining it as a class method, I.e.

def Payment.monthly_payment
  # etc.
end

Sorry for bad formatting, I'm on mobile.

edited Apr 09 '15 at 14:29

MrYoshiji

54,334
13
124
117

answered Apr 09 '15 at 14:27

Slaaavo

112
1
11

(I got your back, I edited your post to format the code) – MrYoshiji Apr 09 '15 at 14:29
Seems like while I was writing this on phone, someone had faster fingers :) – Slaaavo Apr 09 '15 at 14:36

'NoMethodError: undefined method' in Ruby on Rails Model

2 Answers2