onReceive called many times

Question

I have a service that get data from an other application.

When I get date I send message to broadCast in order to refresh the UI.

The onReceive method is called many times and data displayed multiple times.

this is my code:

DataService.java

if(sizeLat == 1) {
                                       
   sendMessage("Alerte1;");
                                    
}
else {

   sendMessage("Alerte2;");
}


 private void sendMessage(String message) {
    Log.w("","==> send message");
    Intent intent = new Intent("my-event");
    // add data
    intent.putExtra("message", message);
    LocalBroadcastManager.getInstance(this).sendBroadcast(intent);
 }

MainActivity.java

// handler for received Intents for the "my-event" event 
    private BroadcastReceiver mMessageReceiver = new BroadcastReceiver() {
      @Override
      public void onReceive(Context context, Intent intent) {
          
                      
      Log.e("","Onreceiver");
      String message = intent.getStringExtra("message");
    
        
        if(message.equals("Alerte1")){
      parentItems.add(message);
      adapter.notifyDataSetChanged();
         }}};

@Override
  protected void onResume() {
    Log.d(TAG, "On Resume");
    super.onResume();
    
    // Register mMessageReceiver to receive messages.
    
    LocalBroadcastManager.getInstance(this).registerReceiver(mMessageReceiver,
            new IntentFilter("my-event"));}

How can I resolve the problem ?

That problem can be of your service check whether your service sending you multiple data or may be sending data multiple time. Do debug and check it or print Log to see what is exactly happening. — Pankaj, Apr 06 '15 at 12:12
the methode sendmessage() is called juste one time but onReceive() is called many times — Wafae, Apr 06 '15 at 12:23
You are craeting multiple instances of private BroadcastReceiver mMessageReceiver = new BroadcastReceiver() , make it static or singleton to avoid this behavour. — Boris Pawlowski, Apr 06 '15 at 12:52
Answered here - https://stackoverflow.com/a/46563020/7758211 — Rasool Mohamed, Oct 04 '17 at 11:00
my case - receiver create multi instance so make sure it must be single and try to create instance in oncreate. — Agilanbu, Dec 27 '21 at 12:23

score 6 · Answer 1 · answered Apr 07 '15 at 06:06

6

Put broadcast register line in onCreate and unregister it in onDestroy() method. The line which you have to move from onResume() to onCreate is:-

LocalBroadcastManager.getInstance(this).registerReceiver(mMessageReceiver,
            new IntentFilter("my-event"));}

answered Apr 07 '15 at 06:06

Pankaj

7,908
6
42
65

4

Never ever do that! onDestroy is not guaranteed to be called by the system. – stdout Dec 23 '15 at 08:39
@zgulser http://stackoverflow.com/questions/23846352/registering-unregistering-broadcastreceivers-on-oncreate-ondestroy – AsafK Mar 20 '16 at 14:12
creating instance of the broadcast receiver worked for me. – Gordon developer Jul 17 '17 at 08:29

score 1 · Answer 2 · answered Apr 06 '15 at 12:50

Possibly, you have two instances of the activity living at the same time. Make a breakpoint on the message receiver and check the address of the instance of your activity class and see if they are different each time the onReceive is called.

There are a few reasons why you could have two instances living at the same time, but one of the most common is leaking context within the activity. More on this topic.

score 0 · Answer 3 · edited Jun 29 '22 at 14:06

0

I fixed same problem by unregister BroadcastReceiver in onPause method

LocalBroadcastManager.getInstance(this).unregisterReceiver(mMessageReceiver,new IntentFilter("my-event")));

Register it in OnResume Method

LocalBroadcastManager.getInstance(this).registerReceiver(mMessageReceiver,
            new IntentFilter("my-event"));}

edited Jun 29 '22 at 14:06

Vineesh TP

7,755
12
66
130

answered Oct 26 '16 at 05:10

Manpreet Patil

709
1
6
13

onReceive called many times

3 Answers3