25

Solution:

Add resource files in the add_executable() statement

Problem

(not in the add_library())

Fail to set main window icon.

Notes:

  • When I don't use AUTORCC I run into some compilation problems: QtCore/qglobal.h: no such file or directory. But, I do prefer AUTORCC as a more modern CMake approach.

  • Without the AUTORCC (different CMakeLists.txt than the provided) and Qt-4.6.2 the current code worked. different CMakeLists.txt)

Code

This is a minimized code of my project. Tree:

|- CMakeLists.txt
|- main_window.hpp
|- main_window.cpp
|- main.cpp
|- resources
   | - resources.qrc
   | - images
       | - logo.png

main_window.cpp

#ifndef MAINWINDOW_HPP
#define MAINWINDOW_HPP

#include <QMainWindow>

class MainWindow : public QMainWindow
{
    Q_OBJECT
public:
    MainWindow();
};

#endif

main_window.cpp

#include "main_window.hpp"

MainWindow::MainWindow()
{
    // i tried ":/images.png", ":/resources/images/logo.png", ":/logo.png"
    setWindowIcon(QIcon(":images/logo.png"));    
}

main.cpp

#include <QApplication>
#include "main_window.hpp"

int main(int argc, char *argv[])
{
    QApplication app(argc, argv);

    app.setOrganizationName("Organization");
    app.setApplicationName("Application Example");
    MainWindow mainWin;
    mainWin.show();

    return app.exec();

}

CMakeLists.txt.

cmake_minimum_required(VERSION 3.1)

project(qt_project)

set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
find_package(Qt4 4.6 REQUIRED)

set(QT_USE_QTGUI TRUE)
set(QT_USE_QTXML TRUE)

include(${QT_USE_FILE})
add_definitions(${QT_DEFINITIONS})

// NOTE: it would be more convenient to be able to add the
// resource file here upon the creation of the library
add_library(mylib main_window.cpp)

// SOLVED
// BEFORE: add_executable(qt_test main.cpp)
add_executable(qt_test main.cpp resources/resources.qrc)

target_link_libraries(qt_test
    mylib
    ${QT_LIBRARIES}
)

resources/resources.qrc

<!DOCTYPE RCC><RCC version="1.0">
    <qresource>
        <file>images/logo.png</file>
    </qresource>
</RCC>

Edit

This is the generated qrc_resources.cxx

#include <QtCore/qglobal.h>

static const unsigned char qt_resource_data[] = {
  // /users/ddakop/dev/misc/qt/resources/images/logo.png
  // ... removed hex data
};

static const unsigned char qt_resource_name[] = {
  // images
  // ... removed hex data
    // logo.png
  // ... removed hex data

};

static const unsigned char qt_resource_struct[] = {
  // :
  0x0,0x0,0x0,0x0,0x0,0x2,0x0,0x0,0x0,0x1,0x0,0x0,0x0,0x1,
  // :/images
  0x0,0x0,0x0,0x0,0x0,0x2,0x0,0x0,0x0,0x1,0x0,0x0,0x0,0x2,
  // :/images/logo.png
  0x0,0x0,0x0,0x12,0x0,0x0,0x0,0x0,0x0,0x1,0x0,0x0,0x0,0x0,

};

QT_BEGIN_NAMESPACE

extern Q_CORE_EXPORT bool qRegisterResourceData
    (int, const unsigned char *, const unsigned char *, const unsigned char *);

extern Q_CORE_EXPORT bool qUnregisterResourceData
    (int, const unsigned char *, const unsigned char *, const unsigned char *);

QT_END_NAMESPACE


int QT_MANGLE_NAMESPACE(qInitResources_resources)()
{
    QT_PREPEND_NAMESPACE(qRegisterResourceData)
        (0x01, qt_resource_struct, qt_resource_name, qt_resource_data);
    return 1;
}

Q_CONSTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qInitResources_resources))

int QT_MANGLE_NAMESPACE(qCleanupResources_resources)()
{
    QT_PREPEND_NAMESPACE(qUnregisterResourceData)
       (0x01, qt_resource_struct, qt_resource_name, qt_resource_data);
    return 1;
}

Q_DESTRUCTOR_FUNCTION(QT_MANGLE_NAMESPACE(qCleanupResources_resources))

System

CentOS-5, Qt-4.8.6, CMake-3.2.1, gcc-4.8.2

Dimitris Dakopoulos
  • 683
  • 1
  • 6
  • 18

2 Answers2

39

I think you need to link qrc_resources generated file.

I suppose you know the next info:

http://www.cmake.org/cmake/help/latest/manual/cmake-qt.7.html

Where you can see the next line:

add_executable(myexe main.cpp resource_file.qrc)

More info:

http://www.cmake.org/cmake/help/latest/prop_tgt/AUTORCC.html

starball
  • 20,030
  • 7
  • 43
  • 238
Tarod
  • 6,732
  • 5
  • 44
  • 50
  • 2
    It works fine. Thanks @Tarod. I will comment thought that it is not convenient to carry around the resource files in order to add to the final executable. – Dimitris Dakopoulos Apr 06 '15 at 13:31
  • True. It might be possible to make that more convenient in a future CMake version. – steveire Apr 06 '15 at 13:41
  • Is it usable with a library? I have a similar situation than OP, but I really want to include resources only once in a lib, rather than in every executable that uses it. – CygnusX1 Jun 09 '19 at 07:23
11

I'm not sure if this is new or not, but I have figured out a way to add resources to libraries.

In my library's CMakeLists.txt I have the following:

list (APPEND RESOURCES library.qrc)
qt5_add_resources (RCC_SOURCES ${RESOURCES})

...

add_library(library ${RCC_SOURCES} ${SOURCES})

In the library, in one of my "main classes" (for me, this class was the first thing that gets created in the library and the last thing that gets destroyed), I did the following:

class libClass : public QMainWindow {
  Q_OBJECT

public:
  libClass() : QMainWindow(nullptr, 0) {
    Q_INIT_RESOURCE(library);
  }

  ~libClass() {
    Q_CLEANUP_RESOURCE(library);
  }
};
Chris Walker
  • 111
  • 1
  • 2
  • 1
    Your hint with the `Q_INIT_RESOURCE` was very valuable. Further reading in Qt doc.: [Using Resources in a Library](https://doc.qt.io/qt-5/resources.html). After I got this running with `qt5_add_resources` like recommended in your post, I tried also the alternative with `set(CMAKE_AUTORCC ON)`. Now, the latter works as well. – Scheff's Cat Sep 22 '22 at 12:07