String attribute in Razor as a part of onclick confirmation

Question

I need a confirm window before calling the action specified in Url.Action. My code is:

<a href="@Url.Action("Delete", "OriginalWorks", new {id = w.Id})" 
onclick="return confirm('Do you... '+ @w.Title + '?')"><span></span></a>

Where w is the instance of the OriginalWork class. If I look into HTML of the site, there is the right string value in confirm, but the window doesn't show and the action is called immediately. If a do the same with an int attribute, for example Id:

<a href="@Url.Action("Delete", "OriginalWorks", new {id = w.Id})" 
onclick="return confirm('Do you... '+ @w.Id + '?')"><span></span></a>

It works as expected, showing a message in an confirm window with an value of Id.

I tried Title.toString(), but it doesn't help. I think it would work with Html.ActionLink, but I want to use this because of span in a a element.

Any ideas? Thanks a lot.

Can you confirm what is " the right string value in confirm"? Are there any quotes in the string breaking the javascript? — Judge Bread, Mar 26 '15 at 20:37
Yep. Most likely you've got a stray single quote in your string value, which is causing the JS string to be terminated prematurely and causing a JS error. — Chris Pratt, Mar 26 '15 at 21:12
There were no quotes in the string, I just joined the strings badly, see my answer. Thanks for help! — Margarit, Mar 27 '15 at 13:17

score 0 · Answer 1 · answered Mar 27 '15 at 07:43

0

Try to use HttpUtility.HtmlEncode for your w.Title to awoid escape chars that can break javascript

answered Mar 27 '15 at 07:43

EkzoMan

63
2
7

The problem wasn't in this, but good recommendation, will use. – Margarit Mar 27 '15 at 13:20

Margarit · Accepted Answer · 2015-03-27T13:23:34.157

0

Thanks for help. Solved it now, I didn't realize that the w.Title value was evaluated as a variable (and JavaScript maybe tried to find a variable called like a Title value), not as a string value. It simply works like this:

<a href="@Url.Action("Delete", "OriginalWorks", new {id = w.Id})" 
onclick="return confirm('Do you... @w.Title?')"><span></span></a>

So there is an expected string value of Title.

edited Mar 27 '15 at 13:23

answered Mar 27 '15 at 13:10

Margarit

107
9

String attribute in Razor as a part of onclick confirmation

2 Answers2