ArrayIndexOutOfBoundsException error in parsing JSON data

Question

I am getting ArrayIndexOutOfBoundsException at id[i] = c.getString(TAG_ID);

Here's the code:

for (int i = 0; i < 25; i++) {
    JSONObject c = contacts.getJSONObject(i);
    id[i] = c.getString(TAG_ID);
}

I have checked that JSON file contains 25 objects. I have also tried using i<10 but it still gives same error.

Id is an array ? What is the size of it? – Razib Mar 19 '15 at 15:44 — Razib, Mar 19 '15 at 15:44
pls post logcat error log ... – likith sai Mar 19 '15 at 15:47 — likith sai, Mar 19 '15 at 15:47
thanks but timrau's answer did it – Harshil Pansare Mar 19 '15 at 15:57 — Harshil Pansare, Mar 19 '15 at 15:57

score 5 · Accepted Answer · answered Mar 19 '15 at 15:47

5

id should be an array with at least 25 elements to avoid index out-of-bound.

String [] id = new String[25];

answered Mar 19 '15 at 15:47

timrau

score 2 · Answer 2 · answered Mar 19 '15 at 16:03

2

Initialize id[] array equivalent to loop condition before entering the for loop.

Or

Add null check to array id[] size inside the for loop and Initialize array equivalent to loop condition.

answered Mar 19 '15 at 16:03

Rajesh

Razib · Answer 3 · 2015-03-19T15:56:48.643

1

You declared your id array as -

String id[] = {null};

That is size of your id array is 1. When you are trying to access 25th or 10th array you are getting the ArrayIndexOutOfBoundException.

Redefining your id array may help you -

String[] id = new String[25];

Or better you may use ArrayList then you don't have to think about the size of the array -

List<String> id = new ArrayList<String>(); //declaration of id ArrayList

Then in your for loop you may do this -

for (int i = 0; i < 25; i++) {
    JSONObject c = contacts.getJSONObject(i);
    id.add(c.getString(TAG_ID));
}

Hope it will Help.
Thanks a lot.

edited Mar 19 '15 at 15:56

answered Mar 19 '15 at 15:46

Razib

It gives error as **Type mismatch: cannot convert from String to String[]** – Harshil Pansare Mar 19 '15 at 15:49
did you meant String id[]=new String[25];? – Harshil Pansare Mar 19 '15 at 15:50

3 Answers3