How do I change visibility using a Converter with MenuItem

Question

I need help as i've a UserControl, "myUC" and i want change its visibility when i press a MenuItem. I've following class BoolToVisibilityConverter :

  [ValueConversion(typeof(bool), typeof(Visibility))]
public sealed class BoolToVisibilityConverter : IValueConverter
{
    public Visibility TrueValue { get; set; }
    public Visibility FalseValue { get; set; }

    public BoolToVisibilityConverter()
    {
        // set defaults
        TrueValue = Visibility.Visible;
        FalseValue = Visibility.Collapsed;
    }

    public object Convert(object value, Type targetType,
        object parameter, CultureInfo culture)
    {
        if (!(value is bool))
            return null;
        return (bool)value ? TrueValue : FalseValue;
    }

    public object ConvertBack(object value, Type targetType,
        object parameter, CultureInfo culture)
    {
        if (Equals(value, TrueValue))
            return true;
        if (Equals(value, FalseValue))
            return false;
        return null;
    }
}

I am setting my converter as StaticResource in Windows.Resource

<Window.Resources>
    <vs:BoolToVisibilityConverter x:Key="VisibilityConverter" TrueValue="Visible" FalseValue="Hidden" />
</Window.Resources>

And i've added converter when i call user control in XAML

<uc:Add Visibility="{Binding MyProperty,Converter={StaticResource VisibilityConverter},FallbackValue=Hidden}" />.

I've binding on the property " MyProperty" so:

   private bool _myProperty;

    public bool MyProperty
    {
        get { 
            return _myProperty; 
        }
        set {
            if (_myProperty== true)
                _myProperty= value;
            else
                _myProperty= true;
            OnPropertyChanged("MyProperty");

        }
    }

But when i launch the application, it does not change the visibility of UserControl.

I forgot to mention that i've the MenuItem bindig with ICommand

    <MenuItem Name="mnuAggiungi" Header="_Aggiungi" Command="{Binding MyCommand}"/>

    RelayCommand _add;

    public ICommand MyCommand
    {
        get
        {
            if (_add == null) _add = new RelayCommand(param => this.MyCommandUC());
            return _add;
        }
    }

   public void  MyCommandUC()
    {
    }

I forgot to mention that i've the MenuItem bindig with ICommand

MenuItem Name="mnuAggiungi" Header="_Aggiungi" Command="{Binding MyCommand}"

    RelayCommand _add;
    public ICommand MyCommand
    {
        get
        {
            if (_add == null) _add = new RelayCommand(param => this.MyCommandUC());
            return _add;
        }
    }
   public void  MyCommandUC()
    {
     }

Muds · Answer 1 · 2015-03-18T11:49:47.010

0

in command handler MyCommandUC do this..

public void MyCommandUC
{
    MyProperty = false; // for hidden
}

but saying this I would want to tell you that, your code is quite confusing, sometimes you set visibility to Hidden sometimes you set it to Collapsed, also, you try to set truevalue and FalseValues from xaml but your converter has hard coded values in its constructor there by making it useless to set anything from xaml

--- edit

I just saw this .. and I.. !

set {
        if (_myProperty== true)
            _myProperty= value;
        else
            _myProperty= true;
        OnPropertyChanged("MyProperty");

    }

change above code to

set {
        _myProperty= value;
        OnPropertyChanged("MyProperty");
    }

edited Mar 18 '15 at 11:49

answered Mar 18 '15 at 10:20

Muds

4,006
5
31
53

does your command handler gets hit when you click on menu item – Muds Mar 18 '15 at 10:39
I did not understand, sorry but i use google translator to translate... sorry me – Dansi Mar 18 '15 at 11:56
But if do not want change the visibility with ICommand, How could i do? – Dansi Mar 18 '15 at 11:58
I have changed the answer have a look – Muds Mar 18 '15 at 12:00

score 0 · Answer 2 · answered Mar 18 '15 at 12:15

Value of MyProperty change when click on MenuItem, and i capture click with ICommand. I've think to do so

      _private bool _myProperty;

...

     set
        { _
      myProperty = value; 
               }
      }

    public void  MyCommandUC()
          {
        if (MyProperty == false)
            MyProperty = true;
        else
            MyProperty = false;
         }

but don't work

How do I change visibility using a Converter with MenuItem

2 Answers2