How to mock sling PropertyIterator?

Question

I have following code to test:

  static Set<String> methodToTest(Node crxProductNode, OfflineNodeAction nodeAction, Set<String> allowedAttributes) throws RepositoryException {
        Set<String> changedPropertiesKeys = new HashSet<String>();
        final PropertyIterator crxProductNodeProperties = crxProductNode.getProperties();
        while (crxProductNodeProperties.hasNext()) {
            final String crxNodePropertyName = crxProductNodeProperties.nextProperty().getName();
            if(nodeAction.getProperties(crxNodePropertyName)==null && allowedAttributes.contains(crxNodePropertyName)){
                changedPropertiesKeys.add(crxNodePropertyName);
            }
        }
        return changedPropertiesKeys;
    }

Please advise me how to test following code.

I have problem with Iterator mocking. I don't understand how to mock it.

Crazyjavahacking · Answer 1 · 2015-03-10T20:33:48.630

0

Because the PropertyIterator is received from crxProductNode and it is a parameter passed to the method, it is a book definition of so called "test collaborator".

We should mock out test collaborators, in your case mock the crxProductNode to return another mock of type PropertyIterator and pass it to the method.

The concrete code depends on your mocking framework, but should be something like the following pseudo code:

@Test
public void testMyPropertyIterator() {
    Sut sut = new SUT(); // System Under Test, the class with your method

    Node nodeMock                   = mock(Node.class);
    PropertyIterator mockProperties = mock(PropertyIterator.class);

    when(nodeMock.getProperties()).thenReturn(mockProperties);

    sut.methodToTest(nodeMock, ...);

   // verification or assertions
}

edited Mar 10 '15 at 20:33

answered Mar 10 '15 at 20:23

Crazyjavahacking

9,343
2
31
40

**nodeMock.getProperties()** returns iterator – gstackoverflow Mar 11 '15 at 08:26
This is handled by mocking: when(nodeMock.getProperties()).thenReturn(mockProperties); is syntax from Mockito. – Crazyjavahacking Mar 11 '15 at 08:44
I understand mockito syntax – gstackoverflow Mar 11 '15 at 09:04
mockProperties should be PropertyIterator mock – gstackoverflow Mar 11 '15 at 09:04
Can you provide unit test entirely for my method? collection underlyed the iterator should contains at least 3 elements – gstackoverflow Mar 11 '15 at 09:54

gstackoverflow · Accepted Answer · 2015-03-13T09:34:47.323

0

For this exists class

org.apache.sling.commons.testing.jcr.MockNode

and

MockNodeIterator

edited Mar 13 '15 at 09:34

answered Mar 13 '15 at 09:27

gstackoverflow

36,709
117
359
710

How to mock sling PropertyIterator?

2 Answers2