Spring Controller 400 (Bad Request)

Question

I am getting bad request issue from spring controller. (Reason : The request sent by the client was syntactically incorrect.) Below is my rest call :

Requested payload:

categoty: "Game"
itemDescription: "adas"
itemDiscount: 1
itemName: "asdas"
itemPrice: 1
itemQuantity: 1

Rest Method

 @RequestMapping(value="/addItem", method = RequestMethod.POST,headers="Accept=application/json")
 public  @ResponseBody String createItem(@RequestBody Item item) {

     ItemDAO itemDAO=new ItemDAO(item);      

     try{
         itemDAO.createProduct();
         return "Success";
     }catch(Exception e){  
         System.out.println("Exception occured in item update");
         e.printStackTrace();
         return "Exception occured in item add";
     }  

 }

Model (Just properties)

@Entity  
@Table(name= "Item")
public class Item {

    @Id
    @GeneratedValue(strategy=GenerationType.AUTO)
    @Column(name="id")
    private int id; 
    private String itemName,itemDescription,categoty;   
    private double itemPrice;
    private float itemDiscount;
    private int itemQuantity;
}

Markup

 <div data-ng-show="show=='addProduct'">  
      <p class="{{errorClass}}">{{newProductError}}</p> 
      <h2>Add an Item</h2>
      <form class="form-horizontal" role="form">
        <div class="form-group">
          <label class="control-label col-sm-2" for="email">Item Name</label>
          <div class="col-sm-10">
            <input  class="form-control"  placeholder="Item Name" ng-model="newItem.itemName">
          </div>
        </div>
        <div class="form-group">
          <label class="control-label col-sm-2" for="email">Item Description</label>
          <div class="col-sm-10">
            <input  class="form-control"  placeholder="Item Description" ng-model="newItem.itemDescription">
          </div>
        </div>
        <div class="form-group">
          <label class="control-label col-sm-2" for="email">Item Price</label>
          <div class="col-sm-10">
            <input  class="form-control" type="number" placeholder="Item Price"  ng-model="newItem.itemPrice">
          </div>
        </div>
        <div class="form-group">
          <label class="control-label col-sm-2" for="pwd">Item Discount</label>
          <div class="col-sm-10">          
            <input type="number" class="form-control" id="pwd" placeholder="Item Discount" ng-model="newItem.itemDiscount">
          </div>
        </div>

        <div class="form-group">
          <label class="control-label col-sm-2" for="pwd">Item Quantity</label>
          <div class="col-sm-10">          
            <input type="number" class="form-control" id="pwd" placeholder="Item Quantity" ng-model="newItem.itemQuantity">
          </div>
        </div>
        <div class="form-group">
          <label class="control-label col-sm-2" for="email">Item Category</label>
          <div class="col-sm-10">
            <input  class="form-control"  placeholder="Item Category" ng-model="newItem.categoty">
          </div>
        </div>
        <div class="form-group">        
          <div class="col-sm-offset-2 col-sm-10">
            <button type="submit" class="btn btn-success" ng-click="addItem();">Submit</button>
          </div>
        </div>
      </form>
  </div>

Service

addItem: function(item){
    return $http({
        method : 'POST',
        url : '/Ecomm-Java-Backend/item/addItem',
        data: item,
        heades:{
            'Content-type': 'application/json'
        }
    }).success(function(result){
        console.log(result.length);
        console.log("result success "+ result);
        return result;
    }).error(function(err){
        console.log("result success "+ err);
        return err;
    });     
}

When I invoke the rest call , I'm getting bad request error.

What could be the issue here? Any help would appreciated.

You have a typo `heades`, change it `headers` – iamiddy Mar 08 '15 at 19:07 — iamiddy, Mar 08 '15 at 19:07
also you missed to add `name` attribute to form elments – Pankaj Parkar Mar 08 '15 at 19:07 — Pankaj Parkar, Mar 08 '15 at 19:07
Changed it , but it didn't help – user3440629 Mar 08 '15 at 19:13 — user3440629, Mar 08 '15 at 19:13

iamiddy · Answer 1 · 2015-03-08T19:52:22.273

0

Try this in your Spring controller

@RequestMapping(value="/addItem", method = RequestMethod.POST,consumes=MediaType.APPLICATION_JSON_VALUE)
     public  @ResponseBody String createItem(@RequestBody Item item) {

         ItemDAO itemDAO=new ItemDAO(item);      

         try{
             itemDAO.createProduct();
             return "Success";
         }catch(Exception e){  
             System.out.println("Exception occured in item update");
             e.printStackTrace();
             return "Exception occured in item add";
         }  

     }

and this in your client side

    addItem: function(item){
        return $http({
            method : 'POST',
            url : '/Ecomm-Java-Backend/item/addItem',
            data: {
     categoty: "Game" ,
     itemDescription: "adas", 
     itemDiscount: 1 ,
     itemName: "asdas",
     itemPrice: 1,
     itemQuantity: 1
// get values from item object
},
            headers : { 'Accept': 'application/json',
                'Content-Type': 'application/json'
            }
        }).success(function(result){
            console.log(result.length);
            console.log("result success "+ result);
            return result;
        }).error(function(err){
            console.log("result success "+ err);
            return err;
        });     
    }

edited Mar 08 '15 at 19:52

answered Mar 08 '15 at 19:27

iamiddy

3,015
3
30
33

Are you still getting a 400 ? – iamiddy Mar 08 '15 at 19:34
Yes with cause : The request sent by the client was syntactically incorrect. – user3440629 Mar 08 '15 at 19:35
Ok, that's good your JSON data is not correct/ doesn't correspond to your server's Item object, put here your sample request and the Item class – iamiddy Mar 08 '15 at 19:37
added reuest in the question and model (Item object definition is already present ) – user3440629 Mar 08 '15 at 19:38
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/72524/discussion-between-iamiddy-and-user3440629). – iamiddy Mar 08 '15 at 19:52

user3440629 · Answer 2 · 2015-03-08T20:15:02.563

0

Finally solved changed json data to

categoty: "Game"
description: "test1"
discount: 10
name: "Test"
price: 10
quantity: 10

But still can't figure out why this worked ...

edited Mar 08 '15 at 20:15

answered Mar 08 '15 at 20:09

user3440629

198
9

Spring Controller 400 (Bad Request)

2 Answers2

Linked