Adding a view inside a custom view

Asked Feb 17 '15 at 10:33

Active Feb 17 '15 at 11:07

Viewed 734 times

I am trying to add a progressbar(circular spinner) inside a RelativeLayout. The relativeLayout is visible, however the progressbar doesn't show up. Following is the code I am using but it doesn't seem to work.

public class MyCustomView extends RelativeLayout
{

    RelativeLayout rLayout;
    ProgressBar mProgressbar;

    public void init()
    {

        mProgressbar = new ProgressBar(mContext, null, android.R.attr.progressBarStyle);

        RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);
        params.addRule(RelativeLayout.CENTER_IN_PARENT);
        mProgressbar.setLayoutParams(params);

        rLayout = new RelativeLayout(mContext);
        rLayout.setBackgroundColor(Color.CYAN);

        rLayout.addView(mProgressbar);
        addView(rLayout);
    }

    @Override
    protected void onLayout(boolean changed, int l, int t, int r, int b) {

        if(rLayout != null)
        {
            rLayout.layout(l, t, r, b);
        }
    }

}

What am I doing wrong?

EDIT:

public class MyCustomView extends RelativeLayout
{
    ProgressBar mProgressbar;

    public void init()
    {

        mProgressbar = new ProgressBar(mContext, null, android.R.attr.progressBarStyle);

        RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);
        params.addRule(RelativeLayout.CENTER_IN_PARENT);
        mProgressbar.setLayoutParams(params);

        addView(mProgressbar);
    }

}

Progressbar doesn't even show up now?

My Goals:

Showing ProgressBar in the center of the MyCustomView.

edited Feb 17 '15 at 11:07

asked Feb 17 '15 at 10:33

user2498079

2,872
8
32
60

extend RelativeLayout, not ViewGroup – pskink Feb 17 '15 at 10:35
Just did that. It works but the progressbar isn't centered – user2498079 Feb 17 '15 at 10:38
this is most likely, because you used wrong LayoutParams – pskink Feb 17 '15 at 10:39
I don't see a mistake there. I have also added a rule to center_in_parent – user2498079 Feb 17 '15 at 10:40
do you have onLayout/onMeasure reimplemented? – pskink Feb 17 '15 at 10:41
for `MyCustomView`? I have implemented onLayout for MyCustomView but not the onMeasure. – user2498079 Feb 17 '15 at 10:42
so comment it out for a while and see what happens – pskink Feb 17 '15 at 10:43
If I comment onLayout() , even the RelativeLayout doesn't show up – user2498079 Feb 17 '15 at 10:49
what RelativeLayout? your MyCustomView is a RelativeLayout, why do you need another one? – pskink Feb 17 '15 at 10:49
If I comment onLayout() shown in the code above, rLayout doesn't show up. rLayout is the parent of ProgressBar and rLayout is a child of the CustomView. – user2498079 Feb 17 '15 at 10:51
again: what is RelativeLayout rLayout; for? your MyCustomView is a RelativeLayout, no need for another one – pskink Feb 17 '15 at 10:52
I used rLayout in a thinking that it would help me in centering the Progressbar. Then how can I center the Progressbar, if I add it to MyCustomView directly? – user2498079 Feb 17 '15 at 10:54
you don't have to do anything: when you use proper LayoutParams it will be done automatically – pskink Feb 17 '15 at 11:02
@pskink Please look at the updated code. – user2498079 Feb 17 '15 at 11:07
i run your code and it works correctly – pskink Feb 17 '15 at 11:18
It doesn't showup at all on my device. – user2498079 Feb 17 '15 at 11:28
run it on the emulator and see the view hierarchy using hierarchyviewer, what do you see? – pskink Feb 17 '15 at 11:49
and what does hierarchyviewer show? – pskink Feb 17 '15 at 13:55

Adding a view inside a custom view

0 Answers0