nullable type and a ReSharper warning

Question

I have the following code:

private static LogLevel? _logLevel = null;

public static LogLevel LogLevel
{
    get
    {
        if (!_logLevel.HasValue)
        {
            _logLevel = readLogLevelFromFile();
        }

        return _logLevel.Value;
    }
}

private static LogLevel readLogLevelFromFile() { ... }

I get a ReSharper warning on the return statement about a possible System.InvalidOperationException and it suggests I check _logLevel to see if it is null first. However, readLogLevelFromFile returns LogLevel, not LogLevel?, so there is no way the return statement could be reached when _logLevel is null. Is this just an oversight by ReSharper, or am I missing something?

I don't get this warning using v4.5. What version of ReSharper are you using? — Brandon, May 14 '10 at 16:14

SLaks · Accepted Answer · 2010-05-14T16:24:24.360

5

That looks like a bug in Resharper.

Note, however, that that isn't thread-safe.

The best way to do this is to use a static initializer, like this:

public static LogLevel Instance { get { return Nested.level; } }

class Nested {
    // Explicit static constructor to tell C# compiler
    // not to mark type as beforefieldinit
    static Nested() { }

    internal static readonly LogLevel level = readLogLevelFromFile();
}

edited May 14 '10 at 16:24

answered May 14 '10 at 16:12

SLaks

868,454
176
1,908
1,964

1

that'll change when its instantiated + load it if its not used at all – eglasius May 14 '10 at 16:17
`Cannot resolve symbol 'Instance'`. Did you mean to do a `new Nested()` there? – Sarah Vessels May 14 '10 at 16:22

score 4 · Answer 2 · answered May 14 '10 at 16:14

4

You could refactor it into something like this:

return (_logLevel = _logLevel ?? readLogLevelFromFile()).Value;

Alternatively you can use the built in lazy type (Requires .NET 4.0 or you can roll your own.):

public static LogLevel LogLevel
{
    get { return _logLevel.Value; }
}
private static Lazy<LogLevel> _logLevel = new Lazy<LogLevel>(readLogLevelFromFile);

answered May 14 '10 at 16:14

ChaosPandion

77,506
18
119
157

That actually gives the compiler error `Cannot implicitly convert type 'MyNS.LogLevel?' to 'MyNS.LogLevel'. An explicit conversion exists (are you missing a cast?)`. – Sarah Vessels May 14 '10 at 16:17
@Sarah - Opps, I forgot the call to `Value`. – ChaosPandion May 14 '10 at 16:18

score 0 · Answer 3 · answered May 14 '10 at 16:16

0

Resharper wasn't 'smart' enough to figure it out for you. It is kind of a complex thing to figure out, I would imagine.

I prefer @ChaosPandion's refactoring anyways...

answered May 14 '10 at 16:16

Brian Genisio

47,787
16
124
167

nullable type and a ReSharper warning

3 Answers3

Linked