23

I have a method that should convert a list to an Option of an object, or None if the list is empty.

def listToOption(myList: List[Foo]): Option[Bar] = {
  if(myList.nonEmpty) Some(Bar(myList))
  else None
}

case class Bar(fooList: List[Foo]) {}

For some reason, my solution feels rather inelegant, and not the Scala way. It seems I should be able to use a method on List to do this sort of thing, but I can't wrap my head around it.

Is there a more Scala-like way to do this?

Xavier Guihot
  • 54,987
  • 21
  • 291
  • 190
Cory Klein
  • 51,188
  • 43
  • 183
  • 243
  • 1
    I first thought that you wanted the head of the list when present but then I re-read your question I really do not understand why you would want to do this. It's hard finding a idiomatic way to do stuff when it's not a common operation. It would be nice if you could clarify what you are going to use this functionality for. – Johan S Jan 30 '15 at 20:47
  • From a wider perspective, it was already clear to me that there are some design problems in this class I'm working with, but I chose not to refactor the class and instead try to write something elegant given the weird restraints. My `if-else` solution merely felt lacking, and I thought there could be a better way to do it. – Cory Klein Jan 30 '15 at 20:52
  • I've been doing Scala for about 9 months, and I truly find it to be awesome, but it's both a blessing and a curse that you can do stuff exactly how you want to do it. I would have refactored the crap out of that code. Well thanks for the clarification, and GLHF coding Scala! – Johan S Jan 30 '15 at 20:57

5 Answers5

31

Lee's answer is good, but I think this corresponds to the intention a bit more clearly:

Option(myList).filter(_.nonEmpty).map(Bar)
Alexey Romanov
  • 167,066
  • 35
  • 309
  • 487
17

Starting Scala 2.13, Option has a when builder:

Option.when(condition)(result)

which in our case gives:

Option.when(myList.nonEmpty)(Bar(myList))
// val myList = List[Int]()    =>    Option[Bar] = None
// val myList = List(1, 2)     =>    Option[Bar] = Some(Bar(List(1, 2)))

Also note Option.unless which promotes the opposite condition:

Option.unless(myList.isEmpty)(Bar(myList))
// val myList = List[Int]()    =>    Option[Bar] = None
// val myList = List(1, 2)     =>    Option[Bar] = Some(Bar(List(1, 2)))
Xavier Guihot
  • 54,987
  • 21
  • 291
  • 190
14
myList.headOption.map(_ => Bar(myList))
Lee
  • 142,018
  • 20
  • 234
  • 287
3
import scalaz._; import Scalaz._
myList.toNel.map(Bar)

toNel - is "to non-empty list" here, it returns Option[NonEmptyList] for safety:

scala> case class Bar(a: NonEmptyList[Int])
defined class Bar

scala> List(1,2,3).toNel.map(Bar)
res64: Option[Bar] = Some(Bar(NonEmptyList(1, 2, 3)))

scala> List[Int]().toNel.map(Bar)
res65: Option[Bar] = None
dk14
  • 22,206
  • 4
  • 51
  • 88
3

How about:

Some(myList) collect { case(l@hd::tl) => Bar(l) }

Seems pretty scala-esque to me.

Ben Reich
  • 16,222
  • 2
  • 38
  • 59