QTextStream writes wrong data to file

Question

I try to read and write from same file but get strange behavior. Here is example code :

mainwindow.h

#ifndef MAINWINDOW_H
#define MAINWINDOW_H

#include <QMainWindow>
#include <QTextStream>
#include <QFile>

namespace Ui {
class MainWindow;
}

class MainWindow : public QMainWindow
{
    Q_OBJECT

public:
    explicit MainWindow(QWidget *parent = 0);
    ~MainWindow();

private slots:
    void on_textEdit_textChanged();

private:
    QFile *File;
    QTextStream *FileStream;
    QString TextFromFile;
    Ui::MainWindow *ui;
};

#endif // MAINWINDOW_H

mainwindow.cpp

#include "mainwindow.h"
#include "ui_mainwindow.h"

MainWindow::MainWindow(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);

    File = new QFile;
    File->setFileName("test.txt");
    File->open(QIODevice::ReadWrite | QIODevice::Text);
    FileStream = new QTextStream(File);

    TextFromFile = FileStream->readAll();
    ui->textEdit->setText(TextFromFile);

    File->close();
    File->open(QIODevice::WriteOnly | QIODevice::Truncate | QIODevice::Text);
}

MainWindow::~MainWindow()
{
    delete ui;
}

void MainWindow::on_textEdit_textChanged()
{
    *FileStream << ui->textEdit->toPlainText();
    FileStream->flush();
}

So when i type for example this :
enter image description here
file will change to this :

but i need this :

My aim is to overwrite file every time when i type characters to textedit.

There's no "strange behavior" here at all, this is what you'd expect a stream operator to do. — MrEricSir, Dec 22 '14 at 19:07

Jablonski · Accepted Answer · 2014-12-22T19:24:54.273

3

If you need rewrite file every time then try to do this without pointers. Something like:

void MainWindow::on_textEdit_textChanged()
{    
    QElapsedTimer timer;
    timer.start();  
    QFile file("test.txt");
    if(!file.open(QIODevice::WriteOnly | QIODevice::Text))
        qDebug() << "failed open";
    else
    {
        QTextStream out(&file);
        out << ui->textEdit->toPlainText();
    }
    qDebug() << "The slow operation took" << timer.elapsed() << "milliseconds";
}

QFile destructor will close file at the end of slot.

Output in my case:

The slow operation took 0 milliseconds 
The slow operation took 0 milliseconds

Of course with big data it will be slower, but I think that it is normal approach.

Probably you thought that QIODevice::Truncate should do the trick, but it is wrong. From doc:

If possible, the device is truncated before it is opened. All earlier contents of the device are lost.

But in your code it does not work because you use same stream, you does not open your file every time, you just append new words every time. And flush() just flushes any buffered data waiting to be written to the device.

edited Dec 22 '14 at 19:24

answered Dec 22 '14 at 19:07

Jablonski

18,083
2
46
47

1

I'd worry about correctness first. Fast code that doesn't work isn't all that useful. – Retired Ninja Dec 22 '14 at 19:21
@RetiredNinja Unfortunately I didn't understand you. What's wrong? My code works, I tested it a few minutes ago, it's fine. – Jablonski Dec 22 '14 at 19:30
@Chernobyl Your code is perfect. I was responding the performance comment. – Retired Ninja Dec 22 '14 at 19:31
@RetiredNinja Oh, sorry, I understood :) Just thought that it is for me because of lack of `@username` – Jablonski Dec 22 '14 at 19:33
1

@9vashrotebal There are few approaches to clear file. For example close and open file without `QIODevice::Append` flag, delete file and create it again, but in your code you open file one time and every time write new data without deleting old, so your output is incorrect. In my code, I open file without `QIODevice::Append` flag every time, so all old data deletes and I write something new, to the "clear" file. – Jablonski Dec 22 '14 at 19:38

QTextStream writes wrong data to file

1 Answers1