Javascript - verify empty inputs

Question

<script>
function showUploading() {

    if (document.form['form']['name'].value != "" && 
        document.form['form']['city'].value != "" )) {

        document.getElementById('submit')   .style.visibility = "hidden";
        document.getElementById('uploading').style.visibility = "visible";
    }
}                       
</script>

With above script I'd like to verify if "name" and "city" form inputs are not empty. Somehow I can't get this working, condition is still returning false even if inputs are filled with text. Here are inputs:

<input required="required" id="name" name="name" type="text">
<input required="required" id="city" name="city" type="text">

I was also trying:

if (document.getElementById('name').value != "")

None of the above methods worked for me. Whats wrong here?

where is the code that fires showUploading()? – atmd Dec 19 '14 at 10:13 — atmd, Dec 19 '14 at 10:13
_Whats wrong here?_ Here, nothing. Maybe somewhere else. – emerson.marini Dec 19 '14 at 10:14 — emerson.marini, Dec 19 '14 at 10:14

score 0 · Accepted Answer · answered Dec 19 '14 at 10:14

0

you have an error in your code, there is one closing bracket too much

change

if (document.form['form']['name'].value != "" && 
    document.form['form']['city'].value != "" )) {

to

 if (document.form['form']['name'].value != "" && 
    document.form['form']['city'].value != "" ) {

answered Dec 19 '14 at 10:14

john Smith

17,409
11
76
117

probably this was an issue, and ot works with document.forms, not with document.form. – Tomas Turan Dec 19 '14 at 11:10

score 0 · Answer 2 · answered Dec 19 '14 at 10:17

0

if(  document.getElementById("ValidateUsename").innerHTML =="")
{
alert("box is empty")
}

answered Dec 19 '14 at 10:17

Coder

240
2
4
20

for input field why you will use inner html you should use .value. – Suchit kumar Dec 19 '14 at 10:18

score 0 · Answer 3 · answered Dec 19 '14 at 10:19

There are several things that might be wrong here

firstly you have a javascript issue on you 'if' statement (too many brackets)

you are using ['form'] but there is no form element shown. you have document.getElementById('submit') but there is no submit element shown and you have document.getElementById('uploading') but there is no uploading element.

Without knowing if they exist there is no way of knowing what the problem is. you also say that 'None of the above methods worked for me' but what IS happening? is anything happening, surley you have console errors?

score 0 · Answer 4 · answered Dec 19 '14 at 10:23

try like this: you have syntax error in if condition.

function showUploading() {

    if (document.getElementById('name').value.trim() != "") {// trim to avoid initial spaces
            alert(document.getElementById('name').value);
        //document.getElementById('submit')  .style.visibility = "hidden";
        //document.getElementById('uploading').style.visibility = "visible";
      
      //rest of your code
    }
}

<input required="required" id="name" name="name" type="text">
<input required="required" id="city" name="city" type="text">

<button onclick="showUploading()">click</button>

Javascript - verify empty inputs

4 Answers4