Add throws signature in every method

Question

I'm handling for the first time Exceptions in Java and I want to know if this this the good way to go.

public static void main(String[] args) throws FileNotFoundException {
        submethod();        
    }


    static void submethod() throws FileNotFoundException {
        Scanner scan = new Scanner(new File("file.txt"));

        while (scan.hasNextLine()) {
            // do somethig...
        }
    }

The thing that sounds strange to me is the explicit declaration throws FileNotFoundException also in the main method, otherwise the compiler reports:

error: unreported exception FileNotFoundException; must be caught or declared to be thrown

I wanted to know if I'm doing it wrong. In a more complicated project, where you need to catch much more exceptions, it would become very messy. Is this the better practice to handle exceptions? And why do I need to declare it in both methods?

You need to declare it in both methods, because both methods can throw that exception. You are correct, though, that this can cause method signature bloat. There is an ongoing debate on the subject of checked vs unchecked Exceptions that has been going on for some time now. — azurefrog, Dec 08 '14 at 18:23
`throws` in your `submethod()` is to let the calling block know that there is an Exception that has not been caught. In your `main()` method you need to surround the call of `submethod()` in a `try-catch` block. `throws` on your `main()` method is almost never a good idea (possibly just never). — Drew Kennedy, Dec 08 '14 at 18:24
@DrewKennedy Thank you for the hint. That way sounded wrong to me as well. — fillobotto, Dec 08 '14 at 18:33

M A · Accepted Answer · 2014-12-08T18:32:04.173

Specifying the FileNotFoundException in the throws clause is needed because FileNotFoundException is a checked exception. The other option is to catch the exception and handle it using a try-catch.

It is up to your program requirements to decide on how to handle the exception. For example, if you want to print a certain error message when the exception is thrown, you can catch it:

try {
    Scanner scan = new Scanner(new File("file.txt"));

    while (scan.hasNextLine()) {
        // do somethig...
    }
} catch(FileNotFoundException ex) {
    System.err.println("file.txt was not found");
}

However, in a simple case like the one you have, it would make sense to just terminate the program when the exception occurs. Hence you can just declare the methods to throw the exception as you just did.

In more complex scenarios, you may want to catch the exception, print something to the user, and continue the program. For example, if submethod is used only to read a file provided by the user, then you can keep the throws as it is. However, the caller of the method may want to handle the exception in case it is thrown, and maybe ask the user to re-input another filename.

Best answer since is also giving a larger view of the problem. However, I'll go with try-catch since I got used to it because of C# past experience. — fillobotto, Dec 08 '14 at 18:39

score 0 · Answer 2 · answered Dec 08 '14 at 18:24

You should not handle it like this. You should be catching the error somewhere and handle the exception. You should either catch the error in submethod() or catch it in the main method and handle the exception. The way you have it right now there is no error handling just throwing the error up the stack. Example:

static void submethod() {
    try
    {
        Scanner scan = new Scanner(new File("file.txt"));

         while (scan.hasNextLine()) {
            // do somethig...
         }
    }catch(FileNotFoundException e)
    {
        e.printStackTrace();
        //error handling here
    }
}

Or:

public static void main(String[] args) {
    try
    {
         submethod();
    }catch(FileNotFoundException e)
    {
         e.printStackTrace();
         //error handling code here
    }        
}

In the second case you would throw the FileNotFoundException in your submethod() ie. you would leave the throws declaration in your submethod but not your main method you would handle it there.

score 0 · Answer 3 · answered Dec 08 '14 at 18:25

0

Since your submethod() is not handling FileNotFoundExceptionm exception. The caller of the method need to handle this exception which can be done by enclosing the method call in try catch block or by adding throws to your main method.

answered Dec 08 '14 at 18:25

Priyanka Kotari

146
1
3
15

Add throws signature in every method

3 Answers3