Erasing an element from a vector within a for loop - C++

Question

I'm trying to erase an enemies' health value when they are destroyed and I get the error "No instance of overloaded function "..." matches the argument list if I have the following:

upgradeHealth.erase(inner)

It seems to only accept something like this:

upgradeHealth.erase(upgradeHealth.begin())

I need the element at position inner to be erased so that it matches the enemy that just got destroyed. Here's the for loop:

for (outer = 0; outer < bullets.size(); outer++)              
{
    for (inner = 0; inner < upgrades.size(); inner++)       
    {
        if (upgrades[inner]->HitTest(bullets[outer])) 
        {
            upgradeHealth[inner] -= 1;
            bullets.erase(outer--);
            multiplier += 0.01;
            hasHit = true;
            multiplierTime = 0;
            cout << upgradeHealth[inner] << endl;
            if (upgradeHealth[inner] == 0) 
                upgradeHealth.erase(inner), upgrades.erase(inner), score += 100 * multiplier;
            break;
        }
    }
}

I had considered doing that but glossed over it, however it works so thank you! — StallMar, Dec 04 '14 at 15:15

score 1 · Answer 1 · answered Dec 04 '14 at 15:05

1

There are only two overloaded member functions erase in class std::vector

iterator erase(iterator position);
iterator erase(iterator first, iterator last);

answered Dec 04 '14 at 15:05

Vlad from Moscow

301,070
26
186
335

score 0 · Answer 2 · edited May 23 '17 at 11:50

0

You can only erase an iterator using the erase(...) methods of the std::vector.

You can check this answer for how to get an iterator from an index. Although I would suggest you rethink your algorithm so that you don't need such a conversion.

edited May 23 '17 at 11:50

Community

1
1

answered Dec 04 '14 at 15:16

Alexandru C.

3,337
1
25
27

Erasing an element from a vector within a for loop - C++

2 Answers2