Django admin: Using messages.error still results in confirmation being shown

Question

I've overridden my save_model() function to wrap the obj.save() call in a try/catch.

def save_model(self, request, obj, form, change):
    from concurrency.exceptions import RecordModifiedError
    from django.http import HttpResponse
    try: 

        obj.save()
        # some other stuff

    except RecordModifiedError:
        messages.error(request, "[!] Record modified. Please try again.")
        #self.message_user(request, "[!] Record modified. Please try again.", level="error")

Catching the RecordModifiedError is working, and the data is not saved. However, the confirmation message that appears on a successful save is still showing, as is the error. I have two contradictory messages being shown!

I'm wondering how to prevent the success message from being displayed. Thanks!

EDIT: also tried the self.message_user() function, but it didn't block the success message either.

well?? Did you find the solution for it? I am having the same problem — Öykü, Oct 02 '20 at 07:58

score 0 · Answer 1 · answered Nov 26 '14 at 18:49

0

doesnot it have to be in this way?

try: 

    obj.save()
    messages.error(request, "[!] Record modified.")

except RecordModifiedError:
    messages.error(request, "[!] Record NOT modified. Please try again.")

answered Nov 26 '14 at 18:49

doniyor

36,596
57
175
260

This didn't change the behaviour. Now I see two success messages when I save successfully. Thanks though. – iank Nov 26 '14 at 19:15

score 0 · Answer 2 · answered Nov 29 '14 at 07:30

0

I think this should work:

storage = messages.get_messages(request)
storage.used = True
messages.error(request, "[!] Record modified. Please try again.")

answered Nov 29 '14 at 07:30

dan-klasson

13,734
14
63
101

score 0 · Answer 3 · edited Apr 18 '19 at 20:58

0

I solved this same issue by overwriting the message_user function. I set a flag if there was an error. If the flag is set, then have message_user return, if not set then call the base class message_user using the super function.

edited Apr 18 '19 at 20:58

Adrian W

4,563
11
38
52

answered Apr 18 '19 at 20:35

Mark

1
1

Django admin: Using messages.error still results in confirmation being shown

3 Answers3