Archiving files in directory with 7zip command into single zips

Question

After doing much searching around here, I have managed to put together a batch script that uses 7zip to archive a directory of files. The issue I'm running into is that instead of putting each file into it's own zip, it's archiving the entire folder of files multiple times and simply renaming them to match each file in the folder.

for %%X in (C:\test\*.txt) do "C:\Program Files (x86)\7-Zip\7z.exe" a -tzip "%%X.zip" *.txt

In the code above, the idea is to look in C:\test\ for ALL txt files, and zip them up into individual zip files. It sort of does this, but instead of having multiple zip files with 1 file inside each, I have multiple zip files with EVERY text file inside of them. Each zip being identical except for the name.

Anyone have some ideas? I'm sure I'm just sticking something in the wrong place, but I've tried just about everything I can think of at this point.

But... you are clearly asking 7-zip to create individually named zip files, and then adding `*.txt`. Why are you not passing the filename to zip to 7-zip as well, ie. why are you using *.zip? — Lasse V. Karlsen, Nov 15 '14 at 21:02
What happens if you replace `*.txt` at the end there with `%%X` ? — Lasse V. Karlsen, Nov 15 '14 at 21:02

score 2 · Accepted Answer · answered Nov 15 '14 at 21:05

Let's break down your command:

For every text file in the folder:
```
for %%X in (C:\test\*.txt) do
```
Create a zip file with the same name as the text file, only with .zip added:
```
"C:\Program Files (x86)\7-Zip\7z.exe" a -tzip "%%X.zip"
```
And add all the files in the folder:
```
*.zip
```

Point 3 there is clearly wrong. You want to add the single file that warranted the zip file instead:

"%%X"

The full command should thus look like this:

for %%X in (C:\test\*.txt) do "C:\Program Files (x86)\7-Zip\7z.exe" a -tzip "%%X.zip" "%%X"

That was it! Wow.. I could have swore I tried that 100x. That's what I get for staring at it for too long. — twiztedstudiez, Nov 15 '14 at 22:24

Archiving files in directory with 7zip command into single zips

1 Answers1