Error handling with Either in Scala

Question

This is a followup to my previous question. Suppose I have the following functions:

type Result[A] = Either[String, A] // left is an error message

def f1(a: A): Result[B] = ...
def f2(b: B): Result[C] = ...
def f3(c: C): Result[D] = ...

def f(a: A): Result[D] = for {
  b <- f1(a).right
  c <- f2(b).right
  d <- f3(c).right
} yield d;

Suppose also I would like to add more information to the error message.

 def f(a: A): Result[D] = for {
  b <- { val r = f1(a); r.left.map(_ + s"failed with $a"); r.right }
  c <- { val r = f2(b); r.left.map(_ + s"failed with $a and $b"); r.right }
  d <- { val r = f3(c); r.left.map(_ + s"failed with $a, $b, and $c"); r.right } 
} yield d;

The code looks ugly. How would you suggest improve the code ?

Is there any reason not to append the arguments to the error message within the functions f1, f2, f3? — lea, Oct 31 '14 at 20:23
It is better to use Scalaz' `\/`, which has a right-bias. Scala's `Either` is not meant for this. — , Oct 31 '14 at 21:08

score 1 · Answer 1 · answered Oct 31 '14 at 21:53

The code looks ugly because you're repeating yourself.

Write a method instead! Or an extension method. One of these, maybe:

implicit class StringEitherCanAdd[A](private val e: Either[String, A]) extends AnyVal {
  def info(s: String): Either[String, A] = e.left.map(_ + s)
  def failed(a: Any*): Either[String, A] =
    if (a.length == 0) e
    else if (a.length == 1) e.left.map(_ + s"failed with ${a(0)}")
    else if (a.length == 2) e.left.map(_ + s"failed with ${a(0)} and ${a(1)}")
    else e.left.map(_ + s"failed with ${a.init.mkString(", ")}, and ${a.last}")
}

Now you just

f1(a).info(s"failed with $a").right
f2(b).failed(a,b).right

Error handling with Either in Scala

1 Answers1