Get highest number from inputs

Question

I need a programm, where I can type in numbers and in the end it gives me the highest number. Why doesn't it work like that? What do I need to change?

public class Program
{
    public static void Main()
    {
        double[] input = new double[12];
        for (int i = 1; i <= 12; i++)
        {
            Console.Write(" Type in {0} number:", i);
            input = [Convert.ToInt32(Console.ReadLine())];
        } 

        Console.WriteLine("The highest number is {0}", input.Max(element => Math.Abs(element)));

        Console.ReadKey();
    }
}

You dont need to store all of the inputs entered. Just store the maximum number entered so far and update it only if the user enters a larger number. — artokai, Oct 30 '14 at 18:20
First, you need to be specific about what's not working for you. The code you posted doesn't compile. But what part are you actually having trouble with? — Peter Duniho, Oct 30 '14 at 18:22
`i <= 12` will not work for `double[12]` use `i < 12`. your max index is 11 — RadioSpace, Oct 30 '14 at 18:37

score 1 · Accepted Answer · answered Oct 30 '14 at 18:25

1

You need to make it so its converting to double and also setting to each individual element

 input[i] = Convert.ToDouble(Console.ReadLine());

and then change this because arrray starts at 0

for (int i = 0; i <= 11; i++)

answered Oct 30 '14 at 18:25

Ryan Schlueter

2,223
2
13
19

No problem arrays are kind of confusing when your first get started. – Ryan Schlueter Oct 30 '14 at 18:49

score 0 · Answer 2 · answered Oct 30 '14 at 18:24

As @Ashad Shanto said you must use Convert.ToDouble and you must use input[i] instead of input. So your code should look like:

public class Program
{
    public static void Main()
    {
        double[] input = new double[12];
        for (int i = 0; i < 12; i++)
        {
            Console.Write(" Type in {0} number:", i);
            input[i] = [Convert.ToDouble(Console.ReadLine())];
        } 

        Console.WriteLine("The highest number is {0}", input.Max(element => Math.Abs(element)));

        Console.ReadKey();
    }
}

There's no need to convert to double instead of int, unless non-integer input is actually expected. Of course, in that case there's also no need for the array to be `double[]` instead of `int[]`, so who really knows what the OP actually needs. :) — Peter Duniho, Oct 30 '14 at 18:25

score 0 · Answer 3 · edited Oct 30 '14 at 19:05

0

As @artokai mentioned you don't need to store all entered numbers.

Try the following:

  double heighest = Double.MinValue;
    for (int i = 0; i < 12; i++)
    {
        Console.Write(" Type in {0} number:", i);
        double input = (Convert.ToDouble(Console.ReadLine());
        if (input > heighest)
            heighest = input

    }
    Console.WriteLine("The highest number is {0}", highest);

edited Oct 30 '14 at 19:05

TGlatzer

5,815
2
25
46

answered Oct 30 '14 at 18:25

ToasteR

886
7
20

1

The above assumes no negative inputs. Also, the square bracket before `Convert` doesn't belong. – Peter Duniho Oct 30 '14 at 18:27
The above also assumes that only a double value will be entered by the user. – d.moncada Oct 30 '14 at 18:36

score 0 · Answer 4 · answered Oct 30 '14 at 18:30

Is the requirement to have a Double or Int? Anyways, you can just simple store the highest number each time a new number is entered by doing a simple comparison.

public static void Main()
{
    var currentNumber = 0;
    for (var i = 1; i <= 12; i++)
    {
        Console.Write(" Type in {0} number: ", i);

        var number = Console.ReadLine();
        int result;

        if (int.TryParse(number, out result))
        {
            if (currentNumber < result)
            {
                currentNumber = result;
            }   
        }
    }

    Console.WriteLine("The highest number is {0}", currentNumber);
    Console.ReadKey();
}

Get highest number from inputs

4 Answers4