Decimal from Integer and Invalid Operands *Updated

Question

I am a beginner in C++ and for an assignment I wrote code for a number to English conversion. My problem is getting the decimal from an integer. Upon advice I changed the void expand to a double value and changed the code for getting the decimal, and now I receive an "invalid operands of types double and int to binary operator %" for the remainder of my code. Something to do with (value)?

void expand(double);

int main()

{
 ......
}
void expand(double value)
{
string const ones[20] = 
    { 
     " ...... "
    }           
if(value>1)
    {
    double decimalPart = value - (int)value;
    }
else if(value>=1000)
{
    expand(value/1000);
    cout<<" thousand";
    if(value % 1000)
.....

Just a suggestion: You can cut your code sample down to just relevant methods. There's an awful lot there, and things like your tens array aren't relevant to the solution, so it's a pain to have to filter through that. — AdamMc331, Oct 25 '14 at 17:51
@McAdam331: No, it's not "just a suggestion", actually: it's a requirement. We expect minimal examples on Stack Overflow! — Lightness Races in Orbit, Oct 25 '14 at 18:57
Why are you using floating-point types for currency values? Simply do not do that. — Lightness Races in Orbit, Oct 25 '14 at 18:57
@lightnessracesinorbit fair enough! I was reviewing posts and got this one, and felt I should make that known. I figured 'suggestion' would help me to not sound rude haha. — AdamMc331, Oct 25 '14 at 19:04
@McAdam331: It does. And I don't blame you. Still, I think it's important to point out that this is a required step not an optional extra. — Lightness Races in Orbit, Oct 25 '14 at 19:08
@Lightness Races in Orbit: First time on the forums and corrected the posting of irrelevant code. Thanks. — JUTG, Oct 25 '14 at 21:34
@JUTG: FYI this is not a forum it is a Q&A repository! More like a FAQ. Cheers — Lightness Races in Orbit, Oct 25 '14 at 21:42

Titus · Answer 1 · 2014-10-25T18:05:26.713

1

void expand(int value)

Change the above to double for anything to work

void expand(double value)

Also you can get the decimal part alone by the following after changing the above

double decimalPart = value - (int)value;

edited Oct 25 '14 at 18:05

answered Oct 25 '14 at 17:58

Titus

907
8
18

I changed the datatypes and now the remainder of my code is giving me "invalid operands of types double and int to binary operator %". – JUTG Oct 25 '14 at 21:40

score 0 · Answer 2 · answered Oct 25 '14 at 17:55

value is an int so any arithmetic operation done using it will disregard the decimal part. So what you are doing when passing num into the expand function is casting it as an int. Hence you are removing the decimals.

double foo = 123.45;
expand(foo); // This will take only 123 and disregard the .45

Declare it as a double in void expand(double value) and see what happens.

Decimal from Integer and Invalid Operands *Updated

2 Answers2