wxTextCtrl code to detect numbers only in Python

Question

I have constructed a wxTextCtrl and want to return true if ONLY digits are entered by the user.

Here is my Python code:

@staticmethod    
def isAllDigits(s):

    for char in list(s):
        if not char.isdigit():
            return False
        else:
            break
    return True

And my code that calls isAllDigits:

     if self.firstNum.IsEmpty() or not self.isAllDigits(self.firstNum.GetValue()):
        self.dataInputIsValid = False 
        msgStr = "Your first number is invalid, please enter only enter digits and do not leave the field blank."
        wx.MessageBox(msgStr)

    if self.secondNum.IsEmpty() or not self.isAllDigits(self.secondNum.GetValue()):
        self.dataInputIsValid = False 
        msgStr = "Your second number is invalid, please enter only enter digits and do not leave the field blank."
        wx.MessageBox(msgStr)

For some reason my isAllDigits method is not detecting only digits. For example, If I were to enter "3k5" into the textCtrl, my program returns that "3k5" is all digits and is valid, which is incorrect.

What is wrong with my isAllDigits method?

sundar nataraj · Accepted Answer · 2014-09-22T04:31:22.003

1

You can do this way

@staticmethod    
def isAllDigits(s):
    s=s.split('.')
    if len(s)>2:
       return false

    return all( s.isdigit() for char in s)

or in your method Remove else .. break part

edited Sep 22 '14 at 04:31

answered Sep 22 '14 at 03:32

sundar nataraj

8,524
2
34
46

This worked great! Also if I enter in "3.4" this code above detects the decimal as a non-digit. How could I code in an exception for decimals? Cheers – Philip McQuitty Sep 22 '14 at 03:47
@PhilipMcQuitty try converting them to integer. if they dont convert they are non digits use try: f=int(s) retrun true except: return false – sundar nataraj Sep 22 '14 at 04:23
should I put this as part of my isAllDigits method? – Philip McQuitty Sep 22 '14 at 04:28

Ahmed El-Kabbany · Answer 2 · 2017-03-10T07:58:54.080

This try ... except worked for me on pyqt4 Qlineedit

def textBoxNumbersOnly(QlineEdit):
    if QlineEdit.text()!="-" and QlineEdit.text()!="+":
        try:
            float(QlineEdit.text())
        except ValueError:
            QlineEdit.setText(QlineEdit.text()[:-1])
            QlineEdit.setCursorPosition = len(QlineEdit.text())
    pass

It does not throw an exception if you start with '-' or '+'. It allows floats; does not allow mistakes such as '3.14.14'. It omits the wrong character and moves the cursor to the end of the line. You may need to tweak it to work for your application.

wxTextCtrl code to detect numbers only in Python

2 Answers2