initializing a property inside a constructor when deserializing

Question

I use Xsd2Code to generate classes. However one of the classes causes me a problem with its constructor, because of the loop and throws StackOverflowException.

[System.CodeDom.Compiler.GeneratedCodeAttribute("Xsd2Code", "3.4.0.32990")]
[System.Xml.Serialization.XmlRootAttribute(Namespace = "", IsNullable = true)]
public partial class ApproverType : INotifyPropertyChanged
{
    private ApproverType replacesField;

    public ApproverType()
    {
        this.replacesField = new ApproverType();
    }

    public ApproverType Replaces
    {
        get
        {
            return this.replacesField;
        }
        set
        {
            if ((this.replacesField != null))
            {
                if ((replacesField.Equals(value) != true))
                {
                    this.replacesField = value;
                    this.OnPropertyChanged("Replaces");
                }
            }
            else
            {
                this.replacesField = value;
                this.OnPropertyChanged("Replaces");
            }
        }
    }
}

Yes it will you have created an infinite recursive loop, when the constructor is called it calls itself because it creates another instance of of the class and assigns it to replacesField, which continues until you blow the stack. — Ben Robinson, Sep 17 '14 at 11:40
Remove this.replacesField = new ApproverType(); from constructor — Pavenhimself, Sep 17 '14 at 11:58
posted an update with workaround using a collection of single item — George Polevoy, Sep 17 '14 at 13:22

George Polevoy · Answer 1 · 2014-09-17T13:19:49.463

How is the Replaces property diclared in your XSD? Probably it's a required element, and the tool generates an instance to comply with the contract.

You could then try to change the definition, making it optional.

If it's something like:

<xs:element name="Replaces" type="ApproverType" use="required" />

You then have to change it to:

<xs:element name="Replaces" type="ApproverType" use="optional" />

EDIT: A scheme would be incorrect anyway, because a recursive required element is impossible in xml too:

<ApproverType>
 <Replaces>
   <Replaces>
     <Replaces>
       <Replaces>
        ... infinite
 <Replaces>
 <OtherProperty />
<ApproverType>

EDIT:

One possible workaround would be having a backing property as a collection of single element:

public List<ApproverType> ReplacesWorkaround { ... }

in another part of partial class:

public ApproverType Replaces
{
 get
 {
  return ReplacesWorkaround.SingleOrDefault();
 }
 set
 {
  ReplacesWorkaround.RemoveAll();
  ReplacesWorkaround.Add(value);
 }
}

score 0 · Answer 2 · answered Sep 17 '14 at 12:16

0

The problem is there are other classes like this.. Obviously this tool is somehow buggy. https://xsd2code.codeplex.com/workitem/7419

I am using version 3.4.0.32990. Is there a way to fix this, easily

answered Sep 17 '14 at 12:16

v.g.

1,076
5
19
38

you should be updating original question instead of answering your own question with another quesion – George Polevoy Sep 17 '14 at 13:21

initializing a property inside a constructor when deserializing

2 Answers2