2

I'm having some trouble getting a UIPopover to appear using swift. The code that is commented out works fine in Objective-C, but doesn't work using Swift. When I tap the + in my view controller I do get the "click" in my debugger, however no popover appears.

class PlayerInformationTableViewController: UITableViewController, NSFetchedResultsControllerDelegate, UIPopoverControllerDelegate {

    @IBOutlet weak var addBarButtonItem: UIBarButtonItem!

    var playerInformationViewController = PlayerInformationViewController()
    var popover:UIPopoverController?    = nil

    override func viewDidLoad() {
        super.viewDidLoad()

        /*

        //setup the popover
        _cuesPopoverViewController          = [self.storyboard instantiateViewControllerWithIdentifier:@"CuesPopoverViewController"];
        self.cuesPopover                    = [[UIPopoverController alloc] initWithContentViewController:_cuesPopoverViewController];
        self.cuesPopover.popoverContentSize = CGSizeMake(540, 300);
        self.cuesPopover.delegate           = self;

        */

    playerInformationViewController.storyboard?.instantiateViewControllerWithIdentifier("PlayerInformationViewController")
    popover?.contentViewController = playerInformationViewController
    popover?.popoverContentSize = CGSizeMake(300, 300)
    popover?.delegate = self


        // Uncomment the following line to preserve selection between presentations
        // self.clearsSelectionOnViewWillAppear = false

        // Uncomment the following line to display an Edit button in the navigation bar for this view controller.
        // self.navigationItem.rightBarButtonItem = self.editButtonItem()
    }

@IBAction func addPopover(sender: AnyObject) {

    println("Click")

    popover?.presentPopoverFromBarButtonItem(addBarButtonItem, permittedArrowDirections: UIPopoverArrowDirection.Any, animated: true)

}

Solution

  override func viewDidLoad() {
        super.viewDidLoad()

     }

@IBAction func addPopover(sender: AnyObject) {

    var popoverViewController = self.storyboard?.instantiateViewControllerWithIdentifier("PlayerInformationViewController") as UIViewController
    popoverViewController.modalPresentationStyle = .Popover
    popoverViewController.preferredContentSize   = CGSizeMake(450, 450)

    let popoverPresentationViewController = popoverViewController.popoverPresentationController

    popoverPresentationViewController?.permittedArrowDirections = .Any
    popoverPresentationViewController?.delegate = self
    popoverPresentationViewController?.barButtonItem = sender as UIBarButtonItem

    presentViewController(popoverViewController, animated: true, completion: nil)

}
Paul S.
  • 1,342
  • 4
  • 22
  • 43
  • 2
    You're using `?.` everywhere. This means that if something is indeed `nil`, you won't find out about that. As a first step in debugging, try to resolve the optionals (obtain their value with `if let x = ..`) and use that value. – Jesper Sep 16 '14 at 13:31

3 Answers3

6

Here is a simple example for iOS 8. Popover are presented using adaptivity apis in iOS 8.

class PlayerInformationTableViewController: UITableViewController, UIPopoverPresentationControllerDelegate, NSFetchedResultsControllerDelegate{

   ...


  @IBAction func addPopover(sender: UIBarButtonItem){
    let playerInformationViewController =  PlayerInformationViewController()
    playerInformationViewController.modalPresentationStyle = .Popover
    playerInformationViewController.preferredContentSize = CGSizeMake(300, 300)



    let popoverPresentationViewController = playerInformationViewController.popoverPresentationController
    popoverPresentationViewController?.permittedArrowDirections = .Any
    popoverPresentationViewController?.delegate = self
    popoverPresentationController?.barButtonItem = sender
    presentViewController(playerInformationViewController, animated: true, completion: nil)
  }


  func adaptivePresentationStyleForPresentationController(controller: UIPresentationController!) -> UIModalPresentationStyle{
    return .None
  }

}
Sandeep
  • 20,908
  • 7
  • 66
  • 106
  • This works great, with a minor typo. popoverPresentationViewController?.barButtonItem = sender as UIBarButtonItem. now that the popover "pops" why isn't it showing what I have in the interface builder? – Paul S. Sep 16 '14 at 14:17
  • The problem with this code above is that, I am instantiating a new viewController from the code. So, if you use storyboard to instantiate your viewController, that probably solves your problem of now showing the UI elements in interface builder. – Sandeep Sep 16 '14 at 14:19
  • How would I add playerInformationViewController.storyboard?.instantiateViewControllerWithIdentifier("PlayerInformationViewController") to use my storyboard, and not create a new view controller? – Paul S. Sep 16 '14 at 14:22
  • Use self.storyboard?.instantiateViewControllerWithIdentifier("PlayerInformationViewControllerIdentifier") if you are using storyboard for your application. – Sandeep Sep 16 '14 at 14:24
  • still shows a new UIViewController if I add self.storyboard?. the view controller that I want to use as the popover is PlayerInformationViewController – Paul S. Sep 16 '14 at 14:50
  • You might be doing something wrong. Is this PlayerInformationViewController being loaded from storyboard ? – Sandeep Sep 16 '14 at 14:58
  • Posted solution. Thanks @insane-36 – Paul S. Sep 16 '14 at 15:05
1

Display Popover with contentView from xib

func showPopover(sender: AnyObject) {

    let contentViewController = UINib(nibName: "ContentVC", bundle: nil).instantiateWithOwner(nil, options: nil)[0] as ContentVC
    contentViewController.modalPresentationStyle = UIModalPresentationStyle.Popover

    var detailPopover: UIPopoverPresentationController = contentViewController.popoverPresentationController!
    detailPopover.delegate = self
    detailPopover.barButtonItem = sender as UIBarButtonItem
    detailPopover.permittedArrowDirections = UIPopoverArrowDirection.Any
    presentViewController(contentViewController,
        animated: true, completion:nil)
}

Next allows to make not full screen PopoverView on iPhone for this do not forget to inherit MainViewController: UIPopoverPresentationControllerDelegate and set delegate to PopoverView

func adaptivePresentationStyleForPresentationController(controller: UIPresentationController!) -> UIModalPresentationStyle 
{
    return .None
}
Pang
  • 9,564
  • 146
  • 81
  • 122
Svitlana
  • 2,938
  • 1
  • 29
  • 38
0

It looks like your popover is nil. Where are you assigning/instantiating it?

Try changing this:

popover?.presentPopoverFromBarButtonItem(addBarButtonItem, permittedArrowDirections: UIPopoverArrowDirection.Any, animated: true)

To this:

if let pop = popover {
    pop.presentPopoverFromBarButtonItem(addBarButtonItem, permittedArrowDirections: UIPopoverArrowDirection.Any, animated: true)
} else {
    NSLog("Error: Popover was nil")
}

I imagine you'll see that error message in your console. In the .XIB for your PlayerInformationTableViewController, do you have a UIPopoverController?

If so, you probably need to ensure that the var popover is either (1) being manually instantiated in your awakeFromNib, or that it's an @IBOutlet and is being connected properly.

Alternatively, can you simply use the popover already present in your playerInformationViewController?

Craig Otis
  • 31,257
  • 32
  • 136
  • 234