I see 2 major problems:
1) Your REN command must have the full path to the source file. You are providing the name and extension only.
2) It looks like you are attempting to strip out % characters as well. That cannot be done with normal expansion - delayed expansion is required. Also, the % must be doubled.
I see a number of inefficiencies:
1) There is no need for any CALL or GOTO. Both are relatively slow. Everything can be done within one loop using parentheses. The performance difference could be significant if there are many files to process. Note that working with variables that have been set within a block requires delayed expansion.
2) Repeatedly opening and closing your log file to append more information is slow. It is more efficient to enclose an entire block within parentheses and redirect only once.
3) You are attempting to remove : from the name. This is not necessary because Windows file names cannot contain :.
4) You have already set your current directory to the root, so there is no need to include the path when redirecting.
Here are a few points of note for my untested solution below:
1) Delayed expansion is toggled on and off within the loop to protect any ! that may appear within file names or paths. FOR variables are corrupted upon expansion if they contain ! and delayed expansion is enabled.
2) I used echo( instead of echo. to echo a blank line. This syntax looks weird, but it always works. The echo. synyax can fail under certain obscure conditions.
3) I used PUSHD insead of CD to set the current directory to your root. CD will not work properly without the /D option if you are changing the current volume (D: to C: for example)
4) The outer block redirects a non-standard/unused file handle to the logfile. Then within the block, specific outputs are redirected to the logfile handle. This is done so that the logfile does not have to be repeatedly opened, repositioned to end, and closed. Other outputs go to normal stdout.
@echo off
setlocal disableDelayedExpansion
set /a xcount=0
set "root=c:\clients"
Set "logfile=Changed.txt"
pushd "%root%"
3>"%logfile%" (
for /f "delims=" %%F in ('dir /a:-d /o:n /b /s *.pdf *.xls') do (
set "file=%%~fF"
set "old=%%~nxF"
set "new=%%~nxF"
setlocal enableDelayedExpansion
set "new=!new:&=and!"
set "new=!new:#=!"
set "new=!new: LTD.=!"
set "new=!new:%%=!"
if "!new!" neq "!old!" (
set /a xcount+=1
ren "!file!" "!new!"
echo "!file!" "!new!"
echo !xcount! - "!file!" "!new!">&3
)
endlocal
)
echo(>&3
echo End of file>&3
)
popd
pause
exit /b
Note - The solution above implements the rules as you have stated them. But there is a problem. A name like "Acme LTD.pdf" would be renamed "Acmepdf"
UPDATE
Since answering, I've written a handy utility called JREN.BAT that can solve the problem very simply. The utility performs rename operations by doing regular expression search and replace on file names. JREN.BAT is a hybrid JScript/batch script that runs natively on any Windows machine from XP onward.
I've refined your rules a bit so that LTD occurring immediately before the extension preserves the dot for the extension, and LTD. occurring in the middle of the name removes the dot.
Assuming you have JREN.BAT in your current directory, or better yet, somewhere within your PATH, then the following script should do the trick.
renFiles.bat
@echo off
call jren "(&)|(#|%| LTD(?=\.[^.]*$)| LTD\.)" "$1?'and':''" /i /s /j /fm "*.pdf|*.xls" %1 >rename.log
type rename.log
I recommend running the above in test mode using the /T option. It will simply list the proposed rename operations without actually renaming anything.
renFiles /T
After verifying everything looks good, then run again without /T
