How to $_GET php variable in url

Question

I have this PHP code and trying to get the value of the variable language from the url parameters when specified link is clicked.

How do I do this? The code below only gets the value of Java in the first statement and not the values in the elseif statements.

if (isset($_GET['language'])) {

    if ($_GET['language'] = 'Java') {
        $q = 'title:(Java+Developer)';
    }
    elseif ($_GET['language'] = 'PHP') {
        $q = 'title:(PHP+Developer)';
    }
    elseif ($_GET['language'] = 'JavaScript') {
        $q = 'title:(JavaScript+Developer)';
    }
}

Links:

      <li><a href="programming/?language=Java">Java</a></li>
      <li><a href="programming/?language=PHP">PHP</a></li>
      <li><a href="programming/?language=JavaScript">JavaScript</a></li>

It's not `$_GET['language'] = 'Java'`. It should be `$_GET['language'] == 'Java'` — , Jul 17 '14 at 10:31

score 3 · Accepted Answer · answered Jul 17 '14 at 10:31

3

There's a difference between = and ==. One is for assigning, the other for comparing.

In your first if() statement, you're assigning the value Java to $_GET['language'], which will evaluate to Java. This will then be true.

Change the single = in the comparisons to ==, and you should be all set.

answered Jul 17 '14 at 10:31

MatsLindh

49,529
4
53
84

+1 for evaluating to `true` making the `if` valid – DarkBee Jul 17 '14 at 10:33

score 1 · Answer 2 · answered Jul 17 '14 at 10:32

1

You are using a single equals sign. This is an assignment (as you do when defining a variable).

You need to use double equals signs ==. This is how you test equality.

$_GET['language'] == SOME_STRING

In addition, I would recommend using a switch statement instead of multiple if statements:

if ( isset( $_GET[ 'language' ] ) ) {
  switch( $_GET[ 'language' ] ){
    case "Java":
      $q = 'title:(Java+Developer)';
    break;
    case "PHP":
      $q = 'title:(PHP+Developer)';
    break;
    case "JavaScript":
      $q = 'title:(JavaScript+Developer)';
    break;  
  }
}

Using a switch statement will make this code much easier to maintain and also to add extra conditions (other languages).

answered Jul 17 '14 at 10:32

Lix

47,311
12
103
131

1

Would it be better to use "===" to also check the data type that is being received or is it that only strings are passed? – MixedVeg Jul 17 '14 at 10:37
@KartikA - I always promote explicit code - so using a strict equality operator would be a good idea. However, with my switch case example, it is not needed. – Lix Jul 17 '14 at 10:38
Hey sorry just saw your code, in your code it shall not be necessary I agree. – MixedVeg Jul 17 '14 at 10:44

score 0 · Answer 3 · answered Jul 17 '14 at 10:31

0

Check the equal sign! Replace "=" with "=="

answered Jul 17 '14 at 10:31

llullulluis

3,472
3
27
30

score 0 · Answer 4 · answered Jul 17 '14 at 10:34

try with this code

if (isset($_GET['language'])) {

    if ($_GET['language'] == 'Java') {
    $q = 'title:(Java+Developer)';
    }
    elseif ($_GET['language'] == 'PHP') {
    $q = 'title:(PHP+Developer)';
    }
    elseif ($_GET['language'] == 'JavaScript') {
    $q = 'title:(JavaScript+Developer)';
    }
}

score 0 · Answer 5 · answered Jul 17 '14 at 10:36

You are assigning value Java to $_GET["language"] which always returns true. You must compare the value of $_GET["language"] against a string. Compare using == or === operator.

if ($_GET["language"] === "Java") { 
  /* here be dragons */ 
}

It is also good habit to use Yoda Conditions to catch this kind of errors.

if ("Java" === $_GET["language"]) { 
  /* here be dragons */ 
}

score 0 · Answer 6 · edited Jun 20 '20 at 09:12

You are using "=" here which is for assigning the variable some value. Have a look at the use of these:

"=" is used for assigning a value to some variable.
"==" is used for comparison (regardless of the data type). For example if

$var =1 and we evaluate a condition

if($var == TRUE )

The result will be bool True because TRUE is 1 and FALSE is 0 always.

3. "===" comparison based on datatype also. The above condition will evaluate to Bool False because the data types are different.

score -2 · Answer 7 · edited Jul 17 '14 at 11:57

-2

You should use == instead of =.

edited Jul 17 '14 at 11:57

Gottlieb Notschnabel

9,408
18
74
116

answered Jul 17 '14 at 10:31

Simon Guldstrand

488
1
5
24

It would be better to add some explanations about your answer. – Mp0int Jul 17 '14 at 10:59

How to $_GET php variable in url

7 Answers7