Fallback (default) image using Angular JS ng-src

Question

I'm trying to set an image source using data returned from a modal. This is inside an ng-repeat loop:

<div id="divNetworkGrid">
    <div id="{{network.id}}" ng-repeat="network in networks">
        <span>
            <table>
                <tr>
                    <td class="imgContainer">
                        <img ng-src="{{ ('assets/img/networkicons/'+ network.actual + '.png') || 
                                         'assets/img/networkicons/default.png' }}"/>
                    </td>
                </tr>
            </table>
        </span>
    </div>
</div>

As is apparent, I want to populate default.png when the network.actual model property is returned as null. But my code is not picking up the default image, though the first image is coming up fine when available.

I'm sure this is some syntax issue, but cant figure out what's wrong.

I have often wondered how to do this and have tried such things as you have, but it had never seemed to work! Good question! — SM3RKY, Sep 17 '15 at 02:27

score 31 · Answer 1 · answered Sep 22 '15 at 13:57

31

I have just found out, that you can use both ng-src and src on an img tag and if ng-src fails (variable used does not exists etc.), it will automatically fallback to src attribute.

answered Sep 22 '15 at 13:57

kudlajz

1,068
8
15

3

I thinks solution is better if you do not want to write more code. – Parijat Dec 09 '15 at 10:37

score 19 · Answer 2 · answered Mar 10 '16 at 16:56

19

What I imagine is happening is the src is returning a 404 even if network.actual is null. For example, first value:

('assets/img/networkicons/'+network.actual+'.png')

is evaluating to a 404 src URL, something like ('assets/img/networkicons/null.png'). So in the OR selection, it's truth-y, but the resource is 404. In that case, you can set the fallback via onError with something like:

<img ng-src="{{('assets/img/networkicons/'+network.actual+'.png')}}" onerror="this.src='assets/img/networkicons/default.png'" />

CodePen to demo use cases - http://codepen.io/jpost-vlocity/pen/zqqerL

answered Mar 10 '16 at 16:56

jpostdesign

2,548
2
15
15

1

This is perfect if the +network.actual+ var exists but the image does not! – Fergus Dec 23 '16 at 22:25
1

The best solution as to me – Sergey Mell Jan 23 '17 at 13:24
Clean, simple and neat. Works well. – Aine Evans Apr 26 '17 at 07:24
Thanks.. Elegant and simple solution. – Chirag Parmar Nov 23 '17 at 10:43

score 15 · Answer 3 · edited Oct 19 '17 at 14:17

15

angular.module('fallback',[]).directive('fallbackSrc', function () {
    return{
        link: function postLink(scope, element, attrs) {
            element.bind('error', function () {
                angular.element(this).attr("src", attrs.fallbackSrc);
            });
        }
    }
});

<img ng-src="{{url}}" fallback-src="default-image.jpg"/>

angular.module('fallback', []).directive('actualSrc', function () {
    return{
        link: function postLink(scope, element, attrs) {
            attrs.$observe('actualSrc', function(newVal, oldVal){
                 if(newVal != undefined){
                     var img = new Image();
                     img.src = attrs.actualSrc;
                     angular.element(img).bind('load', function () {
                         element.attr("src", attrs.actualSrc);
                     });
                 }
            });

        }
    }
});

<img actual-src="{{url}}" ng-src="default.jpg"/>

link

edited Oct 19 '17 at 14:17

Bartando

719
8
26

answered Oct 06 '14 at 01:34

Subash Selvaraj

3,385
1
14
17

I was reluctant to try this initially because I thought it must be a simpler solution. However, after I tried many suggestions and none of them work perfectly, this is definitely the best one. Thanks! – newman Mar 01 '17 at 02:48
@miliu Glad it helped you :) – Subash Selvaraj Mar 02 '17 at 03:25
1

minor error: first example should use fallback-src as the attribute html code (or fallBackSrc as the directive name). Great solution otherwise! – wal5hy Apr 16 '17 at 19:15

score 10 · Accepted Answer · edited Jan 11 '15 at 18:01

10

Interesting way to use ng-src. I haven't tested how that expression would be handled but I would suggest doing it a more stable way:

<img ng-src="{{ networkIcon }}" />

And in your controller:

$scope.networkIcon = network.actual ? 'assets/img/networkicons/' + network.actual + '.png' : 'assets/img/networkicons/default.png';

Edit: Just to clarify, I'm not suggesting the best way to do this is to bind the image source directly to the scope but rather to move the image fallback logic outside of the view. In my applications I often do it in the services that retrieve the data or on the server itself and send an image URL so the client only has to worry about a single property.

Edit to address repeater:

angular.forEach($scope.networks, function(network) {
  network.icon = network.actual ? 'assets/img/networkicons/' + network.actual + '.png' : 'assets/img/networkicons/default.png';
});

<tr ng-repeat="network in networks">
  <td><img ng-src="{{ network.icon }}" /></td>
</tr>

edited Jan 11 '15 at 18:01

Ed B

849
1
7
25

answered Jul 07 '14 at 15:54

Terry

14,099
9
56
84

1

I should have specified before, but network.actual is actually within an ng-repeat. network is an iteration of the networks model. So this option wouldn't work for me, unfortunately... – nikjohn Jul 07 '14 at 17:08
Yes it will, in my edit paragraph I mentioned I do it in services that retrieve the data. So before you bind to the repeater iterate through your data and replace (or append) the image source. – Terry Jul 07 '14 at 20:38
I've updated my answer with an example of how to modify the data before it hits the repeater. – Terry Jul 07 '14 at 20:42

score 8 · Answer 5 · answered May 28 '15 at 18:02

<div id="divNetworkGrid">
                <div id="{{network.id}}" ng-repeat="network in networks">
                    <span>
                        <table>
                            <tr>
                                <td class="imgContainer">
                                    <img ng-src="{{'assets/img/networkicons/'+(network.actual || 'default' )+'.png'}}"/>
                                </td>
                            </tr>
                        </table>
                    </span>
                </div>
            </div>

The inline or will work if the the queried variable is undefined. The above will fix your issue

score 5 · Answer 6 · edited Aug 07 '16 at 14:15

5

You can supply the alternative image after OR operator like this:

{{ book.images.url || 'Images/default.gif' }}

edited Aug 07 '16 at 14:15

Nikolay Mihaylov

3,868
8
27
32

answered Aug 07 '16 at 12:45

Rajnesh Nadan

91
1
1

Fallback (default) image using Angular JS ng-src

6 Answers6

Linked