grunt-svgstore cleanup option not working

Question

I'm using grunt-svgstore to merge SVG files. There's an option available called 'cleanup' (https://github.com/FWeinb/grunt-svgstore#optionscleanup) that should:

Clean up all inline style definitions that may jeopardise later stylesheet-based colouring (fill).

However, mine doesn't seem to work. The rest of it runs fine, I get the prefix and the viewBox and the file is created. It's just the cleanup that doesn't seem to work. Have I got the syntax wrong here (from my Gruntfile.js)?

svgstore: {
    options: {
        prefix: 'icon-',
        cleanup: true,
        svg: {
            viewBox: '0 0 32 32',
            class: 'is-hidden'
        }
    },
    default: {
        files: {
            'svg/svg-sprite.svg': ['svg/*.svg']
         }
    }
}

score 5 · Answer 1 · answered Oct 08 '14 at 03:16

5

It looks as though you can provide the 'cleanup' option with an array off attributes instead of just true or false. You can add the fill attribute here in the array as well as style attribute if you wanted to.

options: {
    cleanup: ['fill', 'style']
}

Hope this helps for future reference.

answered Oct 08 '14 at 03:16

Ben

51
1
1

This was so helpful thank you! I could not find a reference to this in the docs -- was there one? If not, I think a PR for updated docs is in order. – rpearce Jan 19 '15 at 17:43

score 3 · Accepted Answer · answered Jul 04 '14 at 14:08

I was actually going down the wrong path with the question, but I'll leave it up for reference to anyone who runs into the same problem.

The plugin actually works perfectly as intended, which is to remove all inline styles:

<path style="fill:#000000:">

What it doesn't do is remove styles that are applied just using

<path fill="#000000">

The IcoMoon app that I was using to download my SVG icons colours the icons using the latter, and so the plugin won't remove those. Unfortunately, I had to go through each SVG individually and remove that fill="#000000".

grunt-svgstore cleanup option not working

2 Answers2