how to insert data from database in combox

Question

I'm trying to insert data from my database in a combo box specifically showing all my tables in the combobox here's my connection

private void Form1_Load(object sender, EventArgs e)
{
     string connetionString = null;
     SqlConnection cnn;
     connetionString = "Data Source=ITWORKSDEV01;Initial Catalog=ITWorksDEV";
     cnn = new SqlConnection(connetionString);

     for (int i = 0; i < 5; i++)
     {
         comboBox1.Items.Add(i.ToString());
     }
 }

After update in the question. Still code is not enough. It is recommended to search about the topic — Hassan, Jun 27 '14 at 05:57
YOu're only creating a connection - you're not actually executing any SQL query against the database! — marc_s, Jun 27 '14 at 06:06
Well i try to teach him to try it first. Lets see if it works this time :D — DatRid, Jun 27 '14 at 07:45

score 1 · Answer 1 · edited May 23 '17 at 12:03

1

First of all, which database-type are you using ?

You can look-up the correct connection-code for each database here: http://www.connectionstrings.com/

Second, don't forget to open the connection:

private void Form1_Load(object sender, EventArgs e)
{
     string connetionString = null;
     connetionString = "Data Source=ITWORKSDEV01;Initial Catalog=ITWorksDEV";
     using (SqlConnection cnn = new SqlConnection(connetionString))
     {
         cnn.Open();

After you opened the connection, create a DataReader and a SQL-Statement:

SqlDataReader and SqlCommand

}
}

Closing/Disposing isn't needed here, using makes that job for you.

But stackoverflow is not a place where we write you the code, you have to write it by yourself and if you get errors we can help you.

Good luck!

edited May 23 '17 at 12:03

Community

1
1

answered Jun 27 '14 at 05:59

DatRid

1,169
2
21
46

Note: closing connections is also very important – Sergey Berezovskiy Jul 09 '14 at 07:44
@SergeyBerezovskiy Yes you are right. Closing/Disposing(which includes closing) is important, will add it to the answer. – DatRid Jul 09 '14 at 07:59
Second note :) It's better to use `using` statement to close connection even if exception happens – Sergey Berezovskiy Jul 09 '14 at 08:43
@SergeyBerezovskiy True the second :P Actually I normally use `using`, I think I just wanted to fix the OP's-code and didn't improve it. My bad :) – DatRid Jul 09 '14 at 08:46

how to insert data from database in combox

1 Answers1