why can't I convert all words to uppercase C

Question

I don't know why input capital letters in string are changed to random code

#include<stdio.h>
#include<string.h>
#define length 100
int main()
{
   int count;
   char word[length];
   printf("Please input your word =");
   scanf("%s", &word);
   count=strlen(word);
   int i;
   for(i=0;i<=count;i++)
   {
        if(word[i]>=97||word[i]<=122)
        {
           word[i]+= -32;
        }
        printf(" %c",word[i]);
   }
   return 0;
}

In "if(word[i]>=97||word[i]<=122)" - your condition is true for every value. — Ivan Kuckir, Jun 21 '14 at 06:51
If you tagged this as C++, why is your code 'C'? Turning a word to upper case in C++ is a one-line algorithm call. Second, your loop has a bug -- it has `i` going up to `<=count`. Therefore you're messing around with the null terminator when you shouldn't be. — PaulMcKenzie, Jun 21 '14 at 06:55

score 3 · Answer 1 · answered Jun 21 '14 at 06:50

3

Change:

if(word[i]>=97||word[i]<=122)

To:

if(word[i]>=97 && word[i]<=122)

answered Jun 21 '14 at 06:50

Mahonri Moriancumer

5,993
2
18
28

score 2 · Answer 2 · answered Jun 21 '14 at 06:51

2

You should be using AND operator instead of OR operator in condition.

if(word[i]>=97 && word[i]<=122)    //to specify small character region's upper AND lower bound

and may be try using

word[i] -= 32; //for simplicity

answered Jun 21 '14 at 06:51

Murtaza Zaidi

599
3
14

score 0 · Answer 3 · answered Jun 21 '14 at 06:52

|| -------》 &&

#include<stdio.h>
#include<string.h>
#define length 100
int main()
 {
    int count;
    char word[length];
    printf("Please input your word =");
    scanf("%s", word);
    count=strlen(word);
    int i;
    for(i=0;i<count;i++)
       {
           if(word[i]>=97&&word[i]<=122)
             {
                word[i]+= -32;
             }
           printf(" %c",word[i]);
  }
    return 0;
}

why can't I convert all words to uppercase C

3 Answers3