node busboy + express 4 + ng-file-upload doesn't trigger events

Question

I'm using mean.io stack + ng-file-upload

does anyone know why the events are not triggered ?

client

controller('ArticleParentCtrl', ['$scope', '$timeout', '$upload', function ($scope, $timeout, $upload) {

        $scope.article = {};

        function setPreview(fileReader, index) {
            fileReader.onload = function(e) {
                $timeout(function() {
                    $scope.dataUrls[index] = e.target.result;
                });
            };
        }

        $scope.fileReaderSupported = window.FileReader !== null;
        $scope.uploadRightAway = true;

        $scope.hasUploader = function(index) {
            return (typeof $scope.upload[index] !== 'undefined');
        };
        $scope.abort = function(index) {
            $scope.upload[index].abort();
            $scope.upload[index] = null;
        };

        $scope.onFileSelect = function($files) {
            $scope.selectedFiles = [];
            $scope.progress = [];
            if ($scope.upload && $scope.upload.length > 0) {
                for (var i = 0; i < $scope.upload.length; i++) {
                    if ($scope.upload[i] !== null) {
                        $scope.upload[i].abort();
                    }
                }
            }
            $scope.upload = [];
            $scope.uploadResult = [];
            $scope.selectedFiles = $files;
            $scope.dataUrls = [];
            for (var y = 0; y < $files.length; y++) {
                var $file = $files[y];
                var isImage = /\.(jpeg|jpg|gif|png)$/i.test($file.name);
                if(!isImage){
                    alert('Only images are allowed');
                    return;
                }
                if (window.FileReader && $file.type.indexOf('image') > -1) {
                    var fileReader = new FileReader();
                    fileReader.readAsDataURL($files[y]);
                    setPreview(fileReader, y);
                }
                $scope.progress[y] = -1;
                if ($scope.uploadRightAway) {
                    $scope.start(y);
                }
            }
        };

        $scope.start = function(index) {
            $scope.progress[index] = 0;
            $scope.upload[index] = $upload.upload({
                url :'/articles/api/upload',
                method: 'POST',
                headers: {
                    'x-ng-file-upload': 'lalista'
                },
                data :  $scope.media,
                file: $scope.selectedFiles[index],
                fileFormDataName: 'avatar'
            })
            .then(
                function(response) {
                    $scope.uploadResult.push(response.data);
                    $timeout(function() {
                        $scope.article.avatar =  response.data.avatar;
                    });
                },
                null,
                function(evt) {
                    $scope.progress[index] = parseInt(100.0 * evt.loaded / evt.total);
                })
            .xhr(function(xhr){
                xhr.upload.addEventListener('abort', function(){
                        console.log('aborted complete');
                    }, 
                    false);
            });
        };

    }])

server

exports.upload = function(req, res) {
    var busboy = new Busboy({ headers: req.headers });
    busboy.on('error', function(err){
        console.log(err);
    });
    busboy.on('file', function(fieldname, file, filename, encoding, mimetype) {
      console.log('fieldname');
      console.log(fieldname);
      console.log('file');
      console.log(file);
      console.log('filename');
      console.log(filename);
      console.log('encoding');
      console.log(encoding);
      console.log('mimetype');
      console.log(mimetype);
      //var saveTo = path.join(os.tmpDir(), path.basename(fieldname));
      //file.pipe(fs.createWriteStream(saveTo));
    });
    busboy.on('finish', function() {
      console.log('finish');
    });

};

if I use formidable like:

var form = new formidable.IncomingForm;
form.parse(req, function(err, fields, files){
    console.log(files);
});

the code works fine but I'd like to know whay on earth with busboy doesn't work :(

score 5 · Answer 1 · answered Jun 05 '14 at 22:51

5

You're not piping your request into busboy. You need to do req.pipe(busboy);.

answered Jun 05 '14 at 22:51

mscdex

104,356
15
192
153

I've tried it but I get an undefined for busboy.on if I'm not wrong req.pipe(busboy) its the set up for connect-busboy – Whisher Jun 06 '14 at 07:15
1

The busboy example in your question is using busboy directly. If you are not actually using that code and are using connect-busboy instead, then you need to attach event handlers on `req.busboy` and use `req.pipe(req.busboy);` if you did not set `immediate: true` in the connect-busboy middleware settings. – mscdex Jun 06 '14 at 12:56
I've tried both but the first broke bodyParser() I put it like https://gist.github.com/whisher/84f2ac83894d3e6fb7df btw can you use both bodyParser() and busboy in the app config ? the second give me problem in the post – Whisher Jun 06 '14 at 13:07
The configuration in that gist with connect-busboy should work fine. In your route handlers you'd just do `req.busboy.on('file', ...);` and `req.busboy.on('field', ...);` and after those: `req.pipe(req.busboy);`. If that doesn't work, provide a simple example that fails for you and I will try to reproduce it. Also, you do not need body-parser if you are using busboy. – mscdex Jun 06 '14 at 14:26
The problem with the gist example it's doing so bodyparser() is broken. Thanks for the support if you want to reproduce it use my post code btw I'm using http://mean.io/. thanks again :) – Whisher Jun 06 '14 at 15:23

score 1 · Answer 2 · edited May 23 '17 at 12:08

This works for me

busboy not firing finish event

var Busboy = require('busboy');

exports.upload = function(req, res) {
    var busboy = new Busboy({
        headers: req.headers
    });

    busboy.on('error', function(err) {
        console.log(err);
    });

    busboy.on('file', function(fieldname, file, filename, encoding, mimetype) {
        console.log(fieldname);
        console.log(file);
        console.log(filename);
        console.log(encoding);
        console.log(mimetype);

        // see other question
        file.resume();

    });

    busboy.on('finish', function() {
        console.log('finish');
    });

    return req.pipe(busboy);

};

node busboy + express 4 + ng-file-upload doesn't trigger events

2 Answers2

Linked