Getting out-of-range error when trying to create and populate a vector using a for loop (C++)

Question

I'm trying to create a vector where each element is a multiple of 3 below 1000. I tried two ways, only one of which worked. The non-functioning way was:

int main() {
    vector<int> multiples_of_three;
    for (int i = 0; i <= 1000/3; ++i)
        multiples_of_three[i] = 3*i;
        cout << multiples_of_three[i] << "\n";
}

That gave an out of range error specifically on multiples_of_three[i]. This next bit of code worked:

int main() {
    vector<int> multiples_of_three(334);
    for (int i = 0; i <  multiples_of_three.size(); ++i) {
        multiples_of_three[i] = 3*i;
        cout <<  multiples_of_three[i];
}

So if I defined the size of the vector I could keep it within it's constraints. Why is it that if I try and let the for loop dictate the number of elements I get an out of range error?

Thanks!

Direct assigment may or may not work, typically you would call `push_back` which would check if a resize is required and then create a new vector large enough for the assigment, and copy the members to the new vector — EdChum, Jun 03 '14 at 07:35
I feel the question is answered here. http://stackoverflow.com/questions/11007054/vectorpush-back-vs-vectoroperator — object, Jun 03 '14 at 08:09

vlad_tepesch · Answer 1 · 2014-06-03T07:59:25.430

the default constructor (that is called here: vector<int> multiples_of_three;) creates an empty vector. you can populate them with push_back or better if you know the number of objects you have to add, pass that number to the constructor, so it reserves the required amount of memory at once instead of constantly growing (that means allocating memory and copying the old menory into the new) the vector.

another alternative is to call reserve from the empty default contructed vector and use push_back to populate it. reserve reserves enough memory to keep the required amount of objects but without changing the size of the vector. advantage of reserve is that the default constructor is not called for every object (as it will be done with resize or parameterized constructor) that would be not necessary since you overwrite the the object in your initialization loop right after the creation of the vector.

score 2 · Accepted Answer · answered Jun 03 '14 at 08:09

This works perfectly fine:

#include <iostream>
#include <vector>
using namespace std;

//this one is the edited version

int main() {
    vector<int> multiples_of_three(334);      //notice the change: I declared the size
    for (int i = 0; i <= 1000 / 3; ++i){
        multiples_of_three[i] = 3 * i;
        cout << multiples_of_three[i] << "\n";
    }
    system("pause");
}


Consider these two examples below:

//=========================the following example has errors =====================
int main() {

    vector<int> multiples_of_three;
    multiples_of_three[0] = 0;  // error
    multiples_of_three[1] = 3;  // error

    cout << "Here they are: " << multiples_of_three[0]; cout << endl;
    cout << "Here they are: " << multiples_of_three[1]; cout << endl;

    cout << endl;
    system("pause");

return 0;
}
//============================the following example works==========================

int main() {
    vector<int> multiples_of_three;
    multiples_of_three.push_back(0);
    multiples_of_three.push_back(3);

    cout << "Here they are: " << multiples_of_three[0]; cout << endl;
    cout << "Here they are: " << multiples_of_three[1]; cout << endl;

    cout << endl;
    system("pause");
return 0;
}

So unless, you have declared the size, never use indices directly for assigning values (as in the first example). However, if the values have already been assigned, you can use indices to retrieve the values (as in the 2nd example). And in case, You want to use indices to assign values, first declare the size of the array (as in the edited version)!

score 1 · Answer 3 · answered Jun 03 '14 at 07:34

1

You need to use push_back() rather than add via the indexer.

The indexer can be used for read/write access to a vector only within the bounds.

answered Jun 03 '14 at 07:34

Nick

25,026
7
51
83

score 1 · Answer 4 · answered Jun 03 '14 at 07:34

1

A vector doesn't magically grow in size because you use []. It started out with 0 elements in the first example and you never grew it.

answered Jun 03 '14 at 07:34

MSalters

173,980
10
155
350

Getting out-of-range error when trying to create and populate a vector using a for loop (C++)

4 Answers4