Renaming files with Qt

Question

I'm trying to write a program that renames a certain list of files in a chosen directory with a new extension. Pretty much to replace all .dx90 files with .dx80 files. This is the code that I've written so far and it's not working. All the files are being placed into the failed files list but I'm getting no errors.

#include <QFileDialog>
#include <QString>
#include <QApplication>
#include <QDir>
#include <QStringList>
#include <QTextStream>

QTextStream cout(stdout);

int main(int argc, char* argv[])
{
    QApplication app(argc, argv);

    QString dirName = QFileDialog::getExistingDirectory(0, "Open Directory", QDir::currentPath(), QFileDialog::ShowDirsOnly | QFileDialog::DontResolveSymlinks);
    QDir directory(dirName);

    QStringList filters;
    filters << "*.dx90";
    QStringList files = directory.entryList(filters);

    QStringList changedFiles, failedFiles;

    foreach(QString filename, files)
    {
        QFileInfo info(filename);
        QString rawFileName = filename.section(".", 0, 0);
        QString newName = info.absoluteFilePath().section("/", 0, -2) + "/" + rawFileName + ".dx80";

        bool success = directory.rename(info.absoluteFilePath(), newName);

        if(success)
        {
            changedFiles << info.absoluteFilePath();
        }
        else
        {
            failedFiles << info.absoluteFilePath();
        }
    }   

    return 0;
}

For `newName` something like `QString newName = filename.replace(".dx90", ".dx80");` might be a bit cleaner. — Nicholas Smith, May 29 '14 at 13:50
Thanks I didn't know that I could do that! Will definitely use that instead :) — Nick Corin, May 29 '14 at 16:11

score 3 · Accepted Answer · answered May 29 '14 at 11:32

3

I figured it out. The error I made was in the line:

QFileInfo info(filename);

It was not finding the file as the variable filename was not the absolute path. This made the info variable default to the QFileInfo of the current working directory of the application. I fixed the code by changing that line to:

QFileInfo info(directory.absolutePath() + "/" + filename);

Thanks to anyone that tried to help me fix the code. I hope this helps others that have similar problems.

answered May 29 '14 at 11:32

Nick Corin

2,214
5
25
46

1

It is also better use `QFile::rename(const QString & oldName, const QString & newName)` to rename a file. When using QDir::rename, If oldName is a file (not a directory) that can't be renamed right away, Qt will try to copy oldName to newName and remove oldName. – Nejat May 29 '14 at 11:37

Renaming files with Qt

1 Answers1