Value stops incrementing at 10

Question

I have here a weird problem, this code works but it stops incrementing when it reaches the value of 10 it should be able to +1 and make it 11 but it stops. I don't know what is causing this, really confused right now.

Here is my code:

Dim i As Integer
i = Integer.Parse(TextBox1.Text) + 1
TextBox1.Text = i.toString()

Could there be something that caused this? Any help or advice will be gladly accepted. Thanks in advance

Nonetheless, you didn't provide enough context (especially code) to solve your problem. — sloth, May 23 '14 at 08:36
this code is triggered by a button. i have a starting value of 1. but it stops incrementing when it reaches 10. — Marc Intes, May 23 '14 at 08:39
Have you used the debugger to step through your code to see what happens? — sloth, May 23 '14 at 08:40
Your code looks fine. Either you haven't provided the exact code or you have something else changing the value in the `TextBox`. — Enigmativity, May 23 '14 at 08:47
@Andrew That wouldn't matter, he's accessing the `Text` property. The TextBox doesn't automatically trim off text that doesn't fit. — Cody Gray - on strike, May 24 '14 at 02:49
@CodyGray I assume the OP was looking at the TextBox to see the value. If you make a text box too narrow, it does not show all the text, and there is no visual indication that there is more text. — Andrew Morton, May 24 '14 at 14:35

score 2 · Accepted Answer · edited May 23 '17 at 12:21

If that code is a revision from your other recent question , the relevant code is this:

Private Sub LoadValue( )
    Dim i As Integer    
    Dim cmd As OleDbCommand = New OleDbCommand

    With cmd
        .CommandText = "SELECT MAX(Guard_ID) FROM Guard"
        .CommandType = CommandType.Text
        .Connection = Conn
        .ExecuteNonQuery()

        Dim reader As OleDbDataReader = cmd.ExecuteReader

        If reader.Read Then

           ' posted code seems to be a 
           ' revision of this:
           TextBox1.Text = reader.GetString(0)
           i = TextBox1.Text + 1
           TextBox1.Text = i

            reader.Close()
        End If
    End With
 End With

The problem is not with the incrementing, but running a MAX query on a TEXT column. Consider a table with IDs of {"0", "1", "2", "10", "11"}. What is the MAX value of that series? Since the column is TEXT, a Text Comparison is done, and the answer is not "11" but "2", because the character 2 has a higher value than the character 1 which is the first digit in both "11" and "10" ("10" <> 10 <> "ten").

Once there are 10 records, your MAX query will only ever return "9" because that is the largest value for the first character of any string of numerals.

In code and in databases, things that you want to treat as numbers have to be a numeric type. This is even more true of Date types, converting them to strings doesnt help. The solution is to change the database column type from Text to Integer, perhaps an AutoNumber and let the DB do all that work for you.

Thanks for this. Sorry forgot to mark it as an answer, was very busy during that time. — Marc Intes, Aug 14 '15 at 13:58

score 1 · Answer 2 · answered May 23 '14 at 10:46

I tried this

Private Sub Button1_Click(sender As Object, e As EventArgs) Handles Button1.Click
    Dim i As Integer
    Dim itb As Integer
    'make sure the number in the tb is valid
    If Integer.TryParse(TextBox1.Text, itb) Then
        i = itb + 1
        TextBox1.Text = i.ToString()
    Else
        'not a number
        Stop
    End If
End Sub

and it worked just as expected.

Value stops incrementing at 10

2 Answers2