I get InvalidOperationException when I try to use Metadatatype with a viewmodel

Question

I have a model with certain properties. I use a separated class with the MetadataType to define requirements for properties. I also try to use the same metadata class with a viewmodel defining just a subset of properties. This is a simple example code of the situation for clarification:

[MetadataType(typeof(Metadata))]
class ModelA
{

    public class Metadata
    {
         [Required]
         public object Property1 { get; set; }

         [Required]
         public object Property2 { get; set; }

    }

    public int Property1 { get; set; }
    public int Property2 { get; set; }
}

[MetadataType(typeof(ModelA.Metadata))]
class ViewModelA
{
    public int Property1 { get; set; }
}

The problem is when the razor engine tries to process the view, it throws the an InvalidOperationException with the following error message:

The associated metadata type for type 'ViewModelA' contains the following unknown properties or fields: Property2. Please make sure that the names of these members match the names of the properties on the main type.

In my understanding the problem here is that the metadata contains properties which the the view model does not. However, this way I don't really understand the advantages of having a metadata class. So my questions are

1) Is there a way to prevent of throwing this exception?

2) If not, what it the best pattern to this situation? (like using a model, a viewmodel, which contains the subset of the properties of the model, defining data annotations by keeping the DRY approach).

Erik Funkenbusch · Answer 1 · 2014-05-22T14:29:24.093

MetadataTypeAttribute's are typically used in cases where you want to apply Metadata to auto-generated objects. If you were to apply the metadata to the objects themselves, they would be overwritten when the objects were regenerated.

This is typically done via partial classes. For instance see below. In this case, you create an empty partial class that is the same name as the auto-generated class, it's of course named the same, but you add the MetadataType attribute to it, and you include the nested Metadata class within it.

You do not typically use this with other classes, as other classes would have to have identical (or supersets) of properties.

// Do no edit this class as it is auto generated
public partial class ModelA
{
    public int Property1 { get; set; }
    public int Property2 { get; set; }
}

// This class can be edited
[MetadataType(typeof(ModelA.Metadata))]
public partial class ModelA
{
    public class Metadata
    {
         [Required]
         public object Property1 { get; set; }

         [Required]
         public object Property2 { get; set; }

    }
}

So, to answer your questions:

1) No, you can't prevent the exception, because Metadata has to describe all the properties of it's parent class, and if those properties don't exist, it throws.

2) You would have to create alternate metadata classes. Since this is just as much work as creating a stand-alone view-model, there is no real benefit to using buddy classes for view models that are subsets.

A lot of people get caught up in the DRY concept. The problem is that every software implementation has competing requirements. DRY is often at odds with Single Responsibility Principle.

MetadataTypeAttribute is really more of a hack anyways to deal with the way that the designers generate code. If you're using Code First, then I would strongly discourage using MetadataTypeAttribute.

Thanks for your answer. So MetadataType is designed for auto-generated classes like database first entity framework. However I use code first, so this kind of solution seems useless for me. Actually I'm a bit confused as I've seen this technique in an MVC tutorial (http://www.microsoftvirtualacademy.com/training-courses/developing-asp-net-mvc-4-web-applications-jump-start) so I don't know why they even mentioned it. Maybe I will review the video. — kexx, May 22 '14 at 14:35
I keep the question opened, as I don't really get what do you mean by creating alternate metadata classes. My goal here is using the data annotations and the validation automatism belongs to it, while defining the constraints only ones, so I'm still looking for a good solution for this. — kexx, May 22 '14 at 14:38
@kexx - I mean, define an alternate metadata class with only Property1. Which, as I said is just as much work as simply having a standalone view model with it's own data attributes. As far as the tutorial, they were probably using it with database first or model first. — Erik Funkenbusch, May 22 '14 at 21:36
"You do not typically use this with other classes, as ***other classes would have to have identical (or supersets) of properties***." - sure wish this was stated _anywhere_ in the docs. — brichins, Mar 28 '18 at 19:58

I get InvalidOperationException when I try to use Metadatatype with a viewmodel

1 Answers1