table showing more than once, How to change?

Question

I have this code that shows a table:

<cfloop  query="GetResults2">
<cfif GetResults2.dept_id eq aFieldValue>     
<table class="table1">
<th>Name</th><th>Positive Comment</th><th>Negative Comment</th>
<tr>
     <td nowrap="nowrap">#emp_namefirst# #Left(emp_namelast, 1)#  </td>
    <td>#Replace(commentpositive, emp_namefirst, "<B>" & emp_namefirst & "</B>")#</td>
    <td>#Replace(commentnegative, emp_namefirst, "<B>" & emp_namefirst & "</B>")#</td>
    </tr>


    </table>
</cfif>
</cfloop>

Right now it does get the correct results but its loopping every time and creating a new table for every row. How can I get it that it will only show one table? I have try moving the

<cfloop query="GetResults2"> inside the table but that doesnt solve the problem. Any suggestions on how to solve it?

Not related to your question, but you are missing tags for your column headers. — Dan Bracuk, May 22 '14 at 13:33
not really missing it it still display well without it, let me add it and see — user3591637, May 23 '14 at 02:59

score 4 · Accepted Answer · answered May 22 '14 at 02:47

This will create one table with a row for each result in the query. The loop needs to be nested within the table and after the header rows.

<table class="table1">
  <th>Name</th>
  <th>Positive Comment</th>
  <th>Negative Comment</th>
  <cfloop  query="GetResults2">
    <cfif GetResults2.dept_id eq aFieldValue>     
      <tr>
        <td nowrap="nowrap">#emp_namefirst# #Left(emp_namelast, 1)#  </td>
        <td>#Replace(commentpositive, emp_namefirst, "<B>" & emp_namefirst & "</B>")#</td>
        <td>#Replace(commentnegative, emp_namefirst, "<B>" & emp_namefirst & "</B>")#</td>
      </tr>
    </cfif>
  </cfloop>    
</table>

score 0 · Answer 2 · answered May 22 '14 at 02:48

0

Move your loop to surround your tr tag.

<table>
    <th>...heading....</th>
    <cfloop query="GetResults2">
        <tr>
            <td>#GetResults2.emp_namefirst# #Left( GetResults2.emp_namelast, 1 )#</td>
        </tr>
    </cfloop>
</table>

answered May 22 '14 at 02:48

Chris Tierney

1,539
1
8
16

table showing more than once, How to change?

2 Answers2