ExecuteScalar null value error

Question

This is my code..

    object o = DBExecuteScalar(myQuery);
    if ((int.parse(o.ToString())) <= 2 || (o is null))
    {
        // my task....
    }

In this code, 'o is null' part is giving error. Any help how to deal with these both conditions in single if statement.. What I want is that the value of o should be (null,0,1,2). Any help ??

Ondrej Svejdar · Answer 1 · 2014-05-07T07:57:36.327

1

With || operator first condition is evaluated first - you want to check if is null first. Also the int.Parse is not necessary. As RGraham mentioned is null is not a proper way how to check for null.

 if (o == null || o == DBNull.Value || (int)o <= 2)

edited May 07 '14 at 07:57

answered May 07 '14 at 07:47

Ondrej Svejdar

21,349
5
54
89

score 1 · Answer 2 · answered May 07 '14 at 07:47

when you reverse the conditions in the if, then it should work.

In your case the ToString is called first on object o. But because o is null this will result in an exception. When you reverse the order of your conditions, then the nullcheck will be first. The second part of the or (||) is only evaluated when the first part is false. This will prevent the exception from occurring

score 1 · Accepted Answer · answered May 07 '14 at 07:50

In C#, the is operator checks for type equality. You need to check for null as o == null:

object o = DBExecuteScalar(myQuery);
if ((o == null) || (int.parse(o.ToString())) <= 2)
{
        // my task....
}

You also need to check for null before you try to perform any actions on it

ExecuteScalar null value error

3 Answers3