29

I'm using the FNV hash as a hashing algorithm on my Hash Table implementation but I'm getting the warning in the question title on this line:

unsigned hash = 2166136261;

I don't understand why this is happening because when I do this:

printf("%u\n", UINT_MAX);
printf("2166136261\n");

I get this:

4294967295
2166136261

Which seems to be under the limits of my machine...

Why do I get the warning and what are my options to get rid of it?

David Sykes
  • 48,469
  • 17
  • 71
  • 80
rfgamaral
  • 16,546
  • 57
  • 163
  • 275

1 Answers1

42
unsigned hash = 2166136261u; // note the u.

You need a suffix u to signify this is an unsigned number. Without the u suffix it will be a signed number. Since

2166136261 > 2³¹ - 1 = INT_MAX,

this integer literal will be problematic.

kennytm
  • 510,854
  • 105
  • 1,084
  • 1,005
  • I assume that doesn't impose any implications in the FNV hashing algorithm and that it will always work as it should? – rfgamaral Feb 27 '10 at 16:23
  • Note that the code is well-defined and complies with all versions of C Standard -- the suffix is only "need"ed to silence a warning which , in this instance, is spurious. – M.M Jan 10 '17 at 01:30