Always getting 0 for integer retrieved from NSUserDefaults

Question

I have an integer stored in user defaults for my game's high score. Every time I start the game I want to check if the score is bigger than the previous high score, so I do this:

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
[defaults setInteger:highScoreNum forKey:@"highScoreNumber"];

if (highScoreNum <= score) {
   highScoreNum = score;

   SKLabelNode *highLabel = (SKLabelNode *)[self childNodeWithName:@"highLabel"];
   highLabel.text = [NSString stringWithFormat:@"%ld", (long)highScoreNum];

   NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
   [defaults setInteger:highScoreNum forKey:@"highScoreNumber"];
}
else if (highScoreNum > score) {
   SKLabelNode *highLabel = (SKLabelNode *)[self childNodeWithName:@"highLabel"];
   highLabel.text = [NSString stringWithFormat:@"%ld", (long)highScoreNum];

   NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
   [defaults setInteger:highScoreNum forKey:@"highScoreNumber"];
}

and at the place where I declare the variable I do this:

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
[defaults setInteger:highScore forKey:@"highScoreNumber"];
highLabel.text = [NSString stringWithFormat:highScore];

but I always get 0 in highScoreNum.

And for the love of Steve, get rid of the else clause and end the if clause after the highScoreNum = score line, so that both conditions use the same label and defaults-setting code. — NRitH, May 31 '14 at 19:51

score 2 · Accepted Answer · answered Apr 30 '14 at 23:16

Every time you do this...

[defaults setInteger:highScore forKey:@"highScoreNumber"];

...you send the highScore variable to the defaults. If you declare highScore, but then don't fetch a previously saved default (or don't otherwise initialize highScore), then it makes sense why you keep seeing zero here. You probably keep sending nil to the defaults, which go in (and come back out) as an integer value of zero.

Immediately after you declare *defaults, instead of calling setInteger:forKey, you probably want to have highScore store the appropriate value from the defaults, which looks like this:

highScore = [defaults integerFromKey:@"highScoreNumber"];

Also, don't forget to [defaults synchronize] when appropriate.

score 0 · Answer 2 · answered Apr 30 '14 at 23:05

0

setInteger:forKey::

Sets the value of the specified default key to the specified integer value.

So your code stores a value to the NSUserDefaults, in several places. It never reads a value back.

(and you should look up -synchronize)

answered Apr 30 '14 at 23:05

Tommy

99,986
12
185
204

score 0 · Answer 3 · answered Apr 30 '14 at 23:24

Try this

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
[defaults setInteger:highScoreNum forKey:@"highScoreNumber"];
[defaults synchronize]; // force the upgrade NSUserDefaults
if (highScoreNum <= score) {
     highScoreNum = score;

     SKLabelNode *highLabel = (SKLabelNode *)[self childNodeWithName:@"highLabel"];
     highLabel.text = [NSString stringWithFormat:@"%ld", (long)highScoreNum];

     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
     [defaults setInteger:highScoreNum forKey:@"highScoreNumber"];
 }
 else if (highScoreNum > score) {
     SKLabelNode *highLabel = (SKLabelNode *)[self childNodeWithName:@"highLabel"];
     highLabel.text = [NSString stringWithFormat:@"%ld", (long)highScoreNum];

     NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
     [defaults setInteger:highScoreNum forKey:@"highScoreNumber"];
     [defaults synchronize]; // force the upgrade NSUserDefaults
 }

Always getting 0 for integer retrieved from NSUserDefaults

3 Answers3