just need to Verify -- Uncaught SyntaxError: Unexpected token else

Question

I am not a js programmer and I have this issue (Uncaught SyntaxError: Unexpected token else)

on one of our pages ...

I strongly believe this is a duplicate of 2 Questions that were answered around this place:

1) Syntax Error: Unexpected token Else 2) Prompt JavaScript If Else Unexpected Token else

So I admit my sin ... (But) I must verify my case is the same %100 for sure( a trailing ; )

So the script is this:

<script type="text/javascript">
if("0" == 0) var t = 'existing' else var t = 'new';
document.write('<scr'+'ipt type="text/javascript" src="//my.domain.com/tag.js?ck=XXX&Retarget=domain:'+t+':psd:sku:XXXXXXXX"></scr'+'ipt>');
</script>

in Chrome .... the error shows after the if statement

Use `{}` around your `if` and `else` blocks. Trust me. It'll make your life 1,000,000x easier. — gen_Eric, Apr 15 '14 at 14:06
Just to know, why are you comparing zero to zero? `Else` will never be performed. — AlieN, Apr 15 '14 at 14:07
@AlieN: It was probably generated via PHP (or other server-side) code. — gen_Eric, Apr 15 '14 at 14:09
indeed it makes no sense to do that compare .. I think @RocketHazmat is right ... not sure though — user3459272, Apr 15 '14 at 14:22
@user3459272: Isn't this your code? You don't know where it came from? — gen_Eric, Apr 15 '14 at 14:24

Fuzzyma · Accepted Answer · 2014-04-15T14:12:20.653

You are missing the ; after your command. If you use more than one command in a line you have to end the command with ; It should be:

<script type="text/javascript">
if("0" == 0) var t = 'existing'; else var t = 'new';
document.write('<scr'+'ipt type="text/javascript" src="//my.domain.com/tag.js?ck=XXX&Retarget=domain:'+t+':psd:sku:XXXXXXXX"></scr'+'ipt>');
</script>

Anyway: Here you see a good reason to use brackets {} instead of the short version

score 2 · Answer 2 · answered Apr 15 '14 at 14:06

2

if("0" == 0) var t = 'existing'; else var t = 'new';

answered Apr 15 '14 at 14:06

davegson

8,205
4
51
71

score 1 · Answer 3 · answered Apr 15 '14 at 14:07

1

Try this:

if("0" == 0) 
{
   var t = 'existing'; 
}
else 
{
   var t = 'new';
}

Although this is very strange that you are comparing "0" == 0

answered Apr 15 '14 at 14:07

Rahul Tripathi

168,305
31
280
331

score 1 · Answer 4 · edited Apr 15 '14 at 19:00

1

Maybe its better to create an inline if to set "t" and this also solves your problem

<script type="text/javascript">
        var t = ("0" == 0) ? 'existing' : 'new';
        document.write('<scr'+'ipt type="text/javascript" src="//my.domain.com/tag.js?ck=XXX&Retarget=domain:'+t+':psd:sku:XXXXXXXX"></scr'+'ipt>');
    </script>

edited Apr 15 '14 at 19:00

gen_Eric

223,194
41
299
337

answered Apr 15 '14 at 14:08

Kapi

547
5
11

just need to Verify -- Uncaught SyntaxError: Unexpected token else

4 Answers4