Copy string data with NULL character inside string to char array

Question

I am trying to copy one string to char array, string have multiple NULL character. My problem is when first NULL character encountered my program stops copying the string.

I have used two approaches. This is what I am so far.

#include<iostream>
#include<string.h>
using namespace std;

int main()
{
    std::string str = "Hello World.\0 How are you?\0";
    char resp[2000];
    int i = 0;
    memset(resp, 0, sizeof(resp));
    /* Approach 1*/
    while(i < str.length())
    {
            if(str.at(i) == '\0')
            str.replace(str.begin(), str.begin()+i, " ");
        resp[i] = str.at(i);
        i++;
    }
    /* Approach 2*/
    memcpy(resp, str.c_str(), 2000);
    cout << resp << endl;
    return 0;
}

This program should print Hello World. How are you?. Please help me to correct this.

If you print `str.length()`, is it 12 or 24(ish)? I think your initialization is wrong. You will need to insert the 0 in the middle manually. — Mats Petersson, Apr 07 '14 at 08:41
I believe `cout` should output string only to the first zero byte anyway, am I wrong? — Ryzhehvost, Apr 07 '14 at 09:06

user657267 · Answer 1 · 2014-04-22T04:17:59.830

1

You could also one-shot it with

std::transform(
  str.begin(), str.end(), resp, [](char c) { return c == '\0' ? ' ' : c; }
);

Of course as @Mats has mentioned your string doesn't have any null chars, strings can also be initialized as follows though:

char const cstr[] = "Hello World.\0 How are you?";
std::string str(cstr, sizeof cstr);

C++14 has a std::string literal operator

std::string str = "Hello World.\0 How are you?"s;

edited Apr 22 '14 at 04:17

answered Apr 07 '14 at 09:22

user657267

20,568
5
58
77

1

This includes the trailing null also; possibly `sizeof cstr - 1` was intended – M.M Apr 07 '14 at 10:12

score 0 · Accepted Answer · answered Apr 07 '14 at 08:42

0

Use std::copy:

std::copy(str.begin(), str.end(), std::begin(resp));

followed by std::replace:

std::replace(std::begin(resp), std::begin(resp) + str.size(), '\0', ' ');

You may want to define your character array so that it is full of zeros at the start:

char resp[2000] = {};

answered Apr 07 '14 at 08:42

juanchopanza

223,364
34
402
480

stringtoarray.cpp:23: error: `begin' is not a member of `std' – someone Apr 07 '14 at 08:46
@someone You must be compiling with a pre-C++11 compiler. You can use `&resp[0]` instead. – juanchopanza Apr 07 '14 at 08:47
1

Of course, that won't help the fact that the `std::string` is only initialized with the C-style string up to the first zero. You can have a std::string with NUL-characters in it, but you can't get it from a C-style string (in the way the original code does, at least). – Mats Petersson Apr 07 '14 at 08:56

Copy string data with NULL character inside string to char array

2 Answers2

Linked