PHP Delete inbox not working properly

Question

I have an inbox code for deleting messages.

If i select one single message it deletes all of them.

How can i fix this ?

Here is my code for delete_message.php :

$inboxbtn = $_POST['deleteinbox'];
$outboxbtn = $_POST['deleteoutbox'];

if($inboxbtn){
    $selectall = $_POST['selectall'];
    if($selectall){
        $query = mysql_query("SELECT * FROM messages WHERE to_user='$user'");
        while ($row = mysql_fetch_assoc($query)){
            mysql_query("UPDATE messages SET to_delete='1' WHERE to_user='$user'");
        }
        echo "All messages have been deleted.";
    }
    else{
        $query = mysql_query("SELECT * FROM messages WHERE to_user='$user'");
        while ($row = mysql_fetch_assoc($query)){
            $msg_id = $row['id'];
            $value = "cb"."$msg_id";
            $checkbox = $_POST[$value];
            if ($value){
            mysql_query("UPDATE `messages` SET `to_delete`='1' WHERE `to_user`='$user' AND `id`='$msg_id'");    
            }
        }       
                echo "The selected messages have been deleted.";
    }

}elseif ($outboxbtn){
    $selectall = $_POST['selectall'];
    if($selectall){
        $query = mysql_query("SELECT * FROM messages WHERE from_user='$user'");
        while ($row = mysql_fetch_assoc($query)){
            mysql_query("UPDATE messages SET from_delete='1' WHERE from_user='$user'");
        }
        echo "All messages have been deleted.";
    }
    else{
    $query = mysql_query("SELECT * FROM messages WHERE from_user='$user'");
        while ($row = mysql_fetch_assoc($query)){
            $msg_id = $row['id'];
            $value = "cb"."$msg_id";
            $checkbox = $_POST[$value];
            if ($value){
            mysql_query("UPDATE messages SET from_delete='1' WHERE to_user='$user' AND id='$msg_id'");
            }   
        }
            echo "The selected messages have been deleted.";    
    }
}
else
    echo "Choose a message to delete.";

And here is the code in inbox.php that has the checkboxes

$query = mysql_query("SELECT * FROM messages WHERE from_user='$user' AND from_delete='0' ORDER BY id DESC");
            $numrows = mysql_num_rows($query);
            if ($numrows != 0){
            echo "<form action='delete_message.php' method='POST'>";
            echo "<div class='messages'>
                    <div class='leftside'><input type='checkbox' name='selectall'><input type='submit' name='deleteoutbox' value='Delete' class'button'></div>
                    <div class='rightside'>Date</div>
                    Subject And Message
                    <div class='clear'></div>
                    <hr>
                </div>";
                while ($row = mysql_fetch_assoc($query)){
                    $msg_id = $row['id'];
                    $msg_to_user = $row['to_user'];
                    $msg_to_id = $row['to_id'];
                    $msg_from_user = $row['from_user'];
                    $msg_from_id = $row['from_id'];
                    $msg_subject = $row['subject'];
                    $content = nl2br($row['content']);
                    $msg_date = $row['date'];
                    $msg_from_delete = $row['from_delete'];
                    $msg_to_delete = $row['to_delete'];

                    if(!$msg_from_delete){
                        echo "<div class='messages'>";
                        echo "<div class='leftside'>
                        <input type='checkbox' name='cb$msg_id' value='$msg_id'>
                        <a href='profile.php?id=$msg_to_id' target='_blank'>$msg_to_user</a>
                        </div>";

                        echo "<div class='rightside'>$msg_date</div>";

                        echo "<div id='center' style='margin-left:150px; margin-right:150px;'>

                        <span class='toggle'><a href='#' onClick='return false'>$msg_subject</a></span>
                        <div class='hiddenDiv'>
                        <br /><hr>
                            <b>$smiles </b>
                            <br><br>


                        </div>
                        </div>";

                        echo "<div class='clear'>";
                        echo "<br /><br /><hr>";
                        echo "</div></div>";
                    }
                }
                echo "</form>";
            }
            else
                echo "You Have No Messages In Your Outbox"

Then for the inbox messages it is the same as the outbox but in the inbox form.

How can i fix this ?

score 1 · Answer 1 · edited Aug 19 '15 at 00:57

instead of directly evaluating a variable which got filled by data that comes from POST,GET global variables, use isset() function first to check weather they got any value, and then the return value of this isset function can be given to if for evaluation.

eg : $inboxbtn = $_POST['deleteinbox'];
$outboxbtn = $_POST['deleteoutbox'];
if(isset($inboxbtn)){
     $selectall = $_POST['selectall'];
    if(isset($selectall)){

 }
}

i think u got problem in this, check this out .... http://in2.php.net/isset https://www.virendrachandak.com/techtalk/php-isset-vs-empty-vs-is_null/

score 0 · Answer 2 · answered Mar 29 '14 at 08:09

also i think your logic to update the message to delete is wrong .

$query = mysql_query("SELECT * FROM messages WHERE to_user='$user'");
        while ($row = mysql_fetch_assoc($query)){
            $msg_id = $row['id'];
            $value = "cb"."$msg_id";
            $checkbox = $_POST[$value];
            if ($value){
            mysql_query("UPDATE `messages` SET `to_delete`='1' WHERE `to_user`='$user' AND `id`='$msg_id'");    
            }
        }

in the above code you are checking variable "$value" in if() condition, this variable for each loop will got some value

$msg_id = $row['id'];
$value = "cb"."$msg_id";

and passes through if, so since while loop will loop through each record that belongs to particular user all his messages are being updated to get DELETE.

if ($value){
            mysql_query("UPDATE `messages` SET `to_delete`='1' WHERE `to_user`='$user' AND `id`='$msg_id'");    
            }

have a look on ur logic ....

I ams till confused. What code should I be using then? – user3474238 Mar 29 '14 at 09:45 — user3474238, Mar 29 '14 at 09:45
Ah. I see the problem but how do I fix it? – user3474238 Mar 29 '14 at 13:19 — user3474238, Mar 29 '14 at 13:19

score 0 · Answer 3 · answered Mar 29 '14 at 18:38

0

In delete_message.php below one is ur code ..

$value = "cb"."$msg_id";
            $checkbox = $_POST[$value];
            if ($value){
            mysql_query("UPDATE `messages` SET `to_delete`='1' WHERE `to_user`='$user' AND `id`='$msg_id'");    
            }

change the code accordingly as give below ....

$value = "cb"."$msg_id";
               if (isset($_POST['$value'])){
                mysql_query("UPDATE `messages` SET `to_delete`='1' WHERE `to_user`='$user' AND `id`='$msg_id'");    
                }

answered Mar 29 '14 at 18:38

Shashidhar Gr

420
2
6
15

Tried this but it didn't delete anything. – user3474238 Mar 29 '14 at 20:20
Any idea on fixing it? – user3474238 Mar 29 '14 at 21:31

PHP Delete inbox not working properly

3 Answers3