toupper function in C

Question

#include <stdio.h>
#include <ctype.h>

char* strcaps(char* s)
{
        while (*s != '\0')
        {
                toupper(*s);
                s++;
        }
        return s;
}

.

int main()
{
        char makeCap[100];
        printf("Type what you want to capitalize: ");
        fgets(makeCap, 100, stdin);
        strcaps(makeCap);
        return 0;
}

this program compiles just fine, but when I run it, it doesn't output anything. what am i missing here?

To begin with, there is no command for showing the result in the output. And the `toupper` return value is ignored... — SJuan76, Mar 23 '14 at 23:01
the command for showing result in output is the return, right? how is topupper ignored, nvm i got java in the mind — Jakkie Chan, Mar 23 '14 at 23:03
Please tag your question *either* with C *or* with Java. Not both. Here you ask a *C* question … — Kijewski, Mar 23 '14 at 23:04

score 1 · Accepted Answer · answered Mar 23 '14 at 23:03

1

You are not printing anything!

Print the return value of toupper().

        printf("%c",toupper(*s));

answered Mar 23 '14 at 23:03

P.P

117,907
20
175
238

score 0 · Answer 2 · answered Mar 23 '14 at 23:02

0

You don't print anything, so of course it won't output anything.

answered Mar 23 '14 at 23:02

Charles Clayton

17,005
11
87
120

BLUEPIXY · Answer 3 · 2014-03-23T23:19:49.520

0

char* strcaps(char* s){
    char *p;
    for (p=s; *p; ++p)
        *p = toupper(*p);//maybe you want to change the original
    return s;//your cord : return address point to '\0'
}
...
//main
printf("%s", strcaps(makeCap));

edited Mar 23 '14 at 23:19

answered Mar 23 '14 at 23:06

BLUEPIXY

39,699
7
33
70

toupper function in C

3 Answers3