javascript what wrong in my function?

Question

I have javascript function to hide or show element but it's not working:

function detail(e) {
    var parent = e.parentNode;
    var next = parent.nextSibling;
    if (next.style.display == 'none') {
        row.style.display = '';
    } else {
        row.style.display = 'none';
    }
}

can anyone help me about this problem ?

thanks

it's still not working, error happened when statement next.style.display, why ?? — user3417215, Mar 23 '14 at 06:51
What's the error message? Is `next` defined when the error occurs? — Ted Hopp, Mar 23 '14 at 06:52
Can you show your selector query? Aka row.... The code is fine but we need to see a larger scope of the code. — Sten Muchow, Mar 23 '14 at 06:57
possible duplicate of [Javascript nextSibling is not working](http://stackoverflow.com/questions/22588071/javascript-nextsibling-is-not-working) — T J, Mar 23 '14 at 07:30

score 1 · Accepted Answer · answered Mar 23 '14 at 07:25

1

parent.nextSibling selects a TEXT_NODE (nodeType = 3), not the next tr

Try this:

var next = parent.nextSibling;
while (next.nodeType != 1) {
   next = next.nextSibling;
}

answered Mar 23 '14 at 07:25

Roland Jansen

2,733
1
16
21

score 0 · Answer 2 · answered Mar 23 '14 at 06:52

0

If the element you are checking for 'display == none', then use:

function detail(e) {
    var parent = e.parentNode;
    var next = parent.nextSibling;
    if (next.style.display == 'none') {
        next.style.display = '';
    } else {
        next.style.display = 'none';
   }   
}

If not, then what is 'row'?

answered Mar 23 '14 at 06:52

bcarn

133
6

problem when program execute "next.style.display", why ?? – user3417215 Mar 23 '14 at 07:01
What is the problem? I need more detail. – bcarn Mar 23 '14 at 07:02
I have two tr and one td, detail(e) where e is td, I call parentNode to get tr first, and call nextSibling to get second tr, but it's not working. Can anyone explain to me ? thanks, – user3417215 Mar 23 '14 at 07:06
Can you show the value of `next.nodeType`? Some browsers insert TEXT_NODE for whitespaces. – Roland Jansen Mar 23 '14 at 07:13
next.nodeType give value = 3, what's problem ? – user3417215 Mar 23 '14 at 07:17

score 0 · Answer 3 · answered Mar 23 '14 at 07:50

A simple example to show/hide a div element.

function fun(){
    var ele = document.getElementById("testDiv");
    if(ele.className==="show"){
        ele.className="hide";
    }
    else{
        ele.className="show";
    }
}

http://jsfiddle.net/imrukhan/7j8ZS/1/

Better if you provide a complete html.

javascript what wrong in my function?

3 Answers3

Linked

Related