How to convert a decimal to binary using for loops?

Question

/* This program converts decimal to binary */

import javax.swing.JOptionPane;

public class BinaryLoop {
public static void main(String []args) {

    String askForDecimal = JOptionPane.showInputDialog("Enter the decimal number you would like to convert?");
    int decimalNumber = Integer.parseInt(askForDecimal);

    int remainder = 0;
    for (int i = 1; decimalNumber > 0; i++) {

            decimalNumber /= 2;
            remainder = decimalNumber % 2;
            System.out.print(remainder);
        }

    }
}

For example I type in 15 but it returns 1110 which should be 1111. p.s. this the result will be read from right to left.

Have you tried printing out `decimalNumber` (or debugging) to see how its value changes? — Anthony Grist, Mar 19 '14 at 10:15

score 3 · Accepted Answer · answered Mar 19 '14 at 10:15

3

decimalNumber /= 2;
remainder = decimalNumber % 2;

These two lines should be in the opposite order. Can you see why?

answered Mar 19 '14 at 10:15

user253751

57,427
7
48
90

score 2 · Answer 2 · answered Mar 19 '14 at 10:15

2

You don't need the variable i in your for loop at all, just use a while loop.

There is a flaw in your algorithm because you are dividing first:

You need to check the remainder before dividing, not afterwards.

answered Mar 19 '14 at 10:15

Tim B

40,716
16
83
128

score 1 · Answer 3 · answered Mar 19 '14 at 10:24

If you understand the intent of the program, you should see the problem if you output some of the intermediate workings:

int remainder = 0;
for (int i = 1; decimalNumber > 0; i++) {
        System.out.println("Entering for() block");
        System.out.println("decimalNumber=" + decimalNumber);
        decimalNumber /= 2;
        System.out.println("decimalNumber=" + decimalNumber);
        remainder = decimalNumber % 2;
        System.out.println(remainder);
    }
}

Examine the output of this and the error should become obvious, which is that because two statements are the wrong way around, you're missing the first, biggest, value of decimalNumber.

You might also notice that remainder is not used outside the block, so you don't need to declare it outside the block, and you don't need to initialise it to zero.

Likewise, you might notice that the value of i is never used, so you could change the for loop to:

 for(;decimalNumber > 0;)

... which is equivalent to:

 while(decimalNumber > 0)

Many people get into the habit of putting temporary println statements in their code to debug. However it's a bad habit. Instead, learn to use a debugger as soon as you can. With a debugger you can pause a program and step through it line by line, looking at the values of all the variables as they change.

score 0 · Answer 4 · answered Mar 19 '14 at 10:24

0

You need to do this:

String s = ""; Integer remainder = 0; while(decimalNumber > 0) { remainder = decimalNumber % 2; decimalNumber /= 2; s = remainder.toString() + s; } System.out.println(s);

answered Mar 19 '14 at 10:24

myusuf

11,810
11
35
50

score 0 · Answer 5 · answered Mar 19 '14 at 11:05

0

you have to change the code to

remainder = decimalNumber % 2;
decimalNumber /= 2;

You have to get the remainder before dividing the number by 2.

answered Mar 19 '14 at 11:05

Meeth

81
7

How to convert a decimal to binary using for loops?

5 Answers5