Remove "/" from the end of a variable

Question

Can any one please tell me how I can remove the slash from the end of a variable

In my index.php I have the following:

$url=$_SERVER['REQUEST_URI'];
include_once "sites/$url.php";

My problem is if I write example.com/test/somefile/ nothing comes but if I write example.com/test/somefile it works

So is there a way to remove the slash if the variable ends with a slash?

you are opening your system to hackers thou. Read up on code injection: http://en.wikipedia.org/wiki/Code_injection — Andresch Serj, Mar 17 '14 at 14:30
Consider someone calling not `/index.html` but `/../../../someSystemConfigFile.conf` — Andresch Serj, Mar 17 '14 at 14:33
Instead of using `$_SERVER['REQUEST_URI']`, use something else, like `dirname(__FILE__)` for instance. — soapergem, Mar 17 '14 at 14:36
emm. I see my site can get hacked with ease. How can I use the dirname(__FILE__)?? — KaareZ, Mar 17 '14 at 17:04
It's not just `FILE`; there are two underscores surrounding each side: `__FILE__`. It's one of PHP's [magic constants](http://www.php.net/manual/en/language.constants.predefined.php). — soapergem, Mar 17 '14 at 18:11
(__FILE__) when I write it it dosent show the __ wtf. But how do I use it?? — KaareZ, Mar 17 '14 at 19:24

score 4 · Answer 1 · answered Mar 17 '14 at 14:29

4

Please do not do this.

You are relying on your user being a goody two shoes and not futzing with requests.

In conclusion: DO NOT rely on browser requests to include a file in your code

answered Mar 17 '14 at 14:29

qwertynl

3,912
1
21
43

score 0 · Accepted Answer · edited Mar 17 '14 at 14:35

0

Try this

$url = rtrim($url, '/');

From PHP.net http://ua2.php.net/rtrim

> You can also specify the characters you want to strip, by means of the character_mask parameter. Simply list all characters that you want to be stripped. With .. you can specify a range of characters.

While this will solve your problem, please take a few minutes to consider the warnings posted in the comments and the other answer(s) regarding code injection since it is a very serious security issue.

edited Mar 17 '14 at 14:35

Andresch Serj

35,217
15
59
101

answered Mar 17 '14 at 14:28

Dean Whitehouse

884
1
8
25

1

Please take advice regarding code injection and http://en.wikipedia.org/wiki/File_inclusion_vulnerability – Dean Whitehouse Mar 17 '14 at 14:38

Remove "/" from the end of a variable

2 Answers2