SyntaxError: invalid syntax ()

Question

I have python 2.7 and I have weather script which returns temperature infos, I would like to implement this script into PostgreSQL. I always got this error: DETAIL: SyntaxError: invalid syntax (<string>, line 10)

code:

    CREATE OR REPLACE FUNCTION GetWeather(lon float, lat float)
    RETURNS float
    AS $$
    import urllib2
    import simplejson as json

    data = urllib2.urlopen(
    "http://api.openweathermap.org/data/2.1/find/station?lat=%s&lon=%s&cnt=1"% (lat, lon))
    js_data = json.load(data)
    if js_data['cod'] == '200': 
    if int(js_data['cnt'])>0: 
    station = js_data['list'][0] 
    print 'Data from weather station %s' %station['name']
    if 'main' in station: 
    if 'temp' in station['main']: 
    temperature = station['main']['temp'] - 273.15 
    else:temperature = None
    else:temperature = None

    return temperature

    $$ LANGUAGE plpythonu;

I tried this version too, but its not working

CREATE OR REPLACE FUNCTION GetWeather(lon float, lat float)
    RETURNS float
    AS $$
    import urllib2
    import simplejson as json

    def get_temp(lat, lon):
    data = urllib2.urlopen(
    "http://api.openweathermap.org/data/2.1/find/station?lat=%s&lon=%s&cnt=1"% (lat, lon))
    js_data = json.load(data)
    try:
    return js_data['list'][0]['main']['temp']
    except (KeyError, IndexError):
        return None

    $$ LANGUAGE plpythonu;

Are those first 3 lines supposed to be part of the Python? And that last line? Because that's not Python. — user2357112, Mar 16 '14 at 22:11
Also the rest of it, if it *is* Python, is wrongly indented. — jonrsharpe, Mar 16 '14 at 22:12
please make break and indent after every `:` as it should be done in Python. There is a good chance that you see what was wrong with your code, it may even be enough to make it working. — m.wasowski, Mar 16 '14 at 22:21

score 1 · Accepted Answer · answered Mar 17 '14 at 22:42

I only have plpython3u, but it should also work for Python 2.7 using plpythonu (just change that part of the following and nothing else).

CREATE OR REPLACE FUNCTION GetWeather(lon float, lat float)
  RETURNS float AS $$
import sys
if sys.version_info[0] == 2:
    from urllib2 import urlopen
else:  # Python 3
    from urllib.request import urlopen
import json

def get_temp(lon, lat):
    data = urlopen(
        "http://api.openweathermap.org/data/2.1/find/station?lat=%s&lon=%s&cnt=1"
        % (lat, lon))
    js_data = json.loads(data.read().decode('utf-8'))
    try:
        return js_data['list'][0]['main']['temp']
    except (KeyError, IndexError):
        return None

return get_temp(lon, lat)
$$ LANGUAGE plpython3u;

Note that the above is with a 4-space indent convention (PEP 8). If you are new to Python, I'd recommend going through a few tutorials to understand the syntax and use of indents.

score 0 · Answer 2 · answered Mar 16 '14 at 22:41

0

You got your data structure wrong (yeah, indentation matters...) Anyway, here is solution for you:

def get_temp(lat, lon):
    data = urllib2.urlopen(
    "http://api.openweathermap.org/data/2.1/find/station?lat=%s&lon=%s&cnt=1"% (lat, lon))
    js_data = json.load(data)
    try:
        return js_data['list'][0]['main']['temp']
    except (KeyError, IndexError):
        return None

Output:

In [121]: get_temp(50,50)
Out[121]: 275.15

answered Mar 16 '14 at 22:41

m.wasowski

6,329
1
23
30

`DETAIL: IndentationError: expected an indented block (, line 10)` – Balazs Mar 16 '14 at 22:50
check in pure python, it works fine - and returns correct results. I have no experience with embedding scripts in postgresql, so I won't be guessing why you get this error. I would recommend reading postgresql documentation on the topic. – m.wasowski Mar 16 '14 at 23:36

SyntaxError: invalid syntax ()

2 Answers2