Xcode 5.1 NSInteger to int, loss of precision

Question

This might be a mundane question, but I would like to know the best practice. Since upgrading to Xcode 5.1, I got a ton of warnings about loss integer precision from NSInteger (aka 'long') to 'int' assuming because of the arm64 switch.

I have been type casting so far to get rid of the warning for example:

int number = (int)[self.arrayOfUsers count];

or should I just use

long number = (int)[self.arrayOfUsers count];

Which is "better"? Should I be mostly using longs now?

Thanks!

score 6 · Accepted Answer · answered Mar 12 '14 at 21:05

6

What you should be doing is using the correct data type:

NSUInteger number = [self.arrayOfUsers count];

Don't needlessly cast to something like int. Use the proper type.

answered Mar 12 '14 at 21:05

rmaddy

314,917
42
532
579

ahh... I guess I should just not use `int` at all it seems – Alan Mar 12 '14 at 21:18
It's always best to use the same data type. – rmaddy Mar 12 '14 at 21:20

score 0 · Answer 2 · answered Mar 12 '14 at 21:05

0

Simply use the same type if you can:

NSUInteger number = [self.arrayOfUsers count];

Your first suggestion:

int number = (int)[self.arrayOfUsers count];

would also work fine as long as you're sure, that the array's count will never go over the integer limit (2^31-1).

answered Mar 12 '14 at 21:05

DrummerB

39,814
12
105
142

Except the `count` method returns an `NSUInteger`, not an `NSInteger`. – rmaddy Mar 12 '14 at 21:07

Xcode 5.1 NSInteger to int, loss of precision

2 Answers2